You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2017/01/17 01:43:07 UTC
Review Request 55595: SENTRY-1428: Only leader should follow HMS
updates
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55595/
-----------------------------------------------------------
Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.
Bugs: SENTRY-1428
https://issues.apache.org/jira/browse/SENTRY-1428
Repository: sentry
Description
-------
- Added LeaderStatusMonitor to HMSFollower
- Minor cleanup of HMSFollower class
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java f3cefd6a232bfb91db28f04bebcc98ab3c1ca658
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java a89d3f6c52e3e6f23794f3a8998ea8a2236886cb
Diff: https://reviews.apache.org/r/55595/diff/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 55595: SENTRY-1428: Only leader should follow HMS
updates
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55595/#review162474
-----------------------------------------------------------
Ship it!
Ship It!
- Hao Hao
On Jan. 20, 2017, 1:28 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55595/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 1:28 a.m.)
>
>
> Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1428
> https://issues.apache.org/jira/browse/SENTRY-1428
>
>
> Repository: sentry
>
>
> Description
> -------
>
> - Added LeaderStatusMonitor to HMSFollower
> - Minor cleanup of HMSFollower class
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java f3cefd6a232bfb91db28f04bebcc98ab3c1ca658
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java a89d3f6c52e3e6f23794f3a8998ea8a2236886cb
>
> Diff: https://reviews.apache.org/r/55595/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 55595: SENTRY-1428: Only leader should follow HMS
updates
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55595/
-----------------------------------------------------------
(Updated Jan. 20, 2017, 1:28 a.m.)
Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.
Bugs: SENTRY-1428
https://issues.apache.org/jira/browse/SENTRY-1428
Repository: sentry
Description
-------
- Added LeaderStatusMonitor to HMSFollower
- Minor cleanup of HMSFollower class
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java f3cefd6a232bfb91db28f04bebcc98ab3c1ca658
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java a89d3f6c52e3e6f23794f3a8998ea8a2236886cb
Diff: https://reviews.apache.org/r/55595/diff/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 55595: SENTRY-1428: Only leader should follow HMS
updates
Posted by Alexander Kolbasov <ak...@gmail.com>.
> On Jan. 19, 2017, 11:57 p.m., Hao Hao wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, line 1
> > <https://reviews.apache.org/r/55595/diff/1/?file=1606269#file1606269line1>
> >
> > I think we should keep the format as "/**" here as the rest header of the files?
Ok, will keep it consistent with other files.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55595/#review162362
-----------------------------------------------------------
On Jan. 17, 2017, 1:43 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55595/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2017, 1:43 a.m.)
>
>
> Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1428
> https://issues.apache.org/jira/browse/SENTRY-1428
>
>
> Repository: sentry
>
>
> Description
> -------
>
> - Added LeaderStatusMonitor to HMSFollower
> - Minor cleanup of HMSFollower class
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java f3cefd6a232bfb91db28f04bebcc98ab3c1ca658
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java a89d3f6c52e3e6f23794f3a8998ea8a2236886cb
>
> Diff: https://reviews.apache.org/r/55595/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 55595: SENTRY-1428: Only leader should follow HMS
updates
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55595/#review162362
-----------------------------------------------------------
Fix it, then Ship it!
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java (line 1)
<https://reviews.apache.org/r/55595/#comment233724>
I think we should keep the format as "/**" here as the rest header of the files?
- Hao Hao
On Jan. 17, 2017, 1:43 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55595/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2017, 1:43 a.m.)
>
>
> Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1428
> https://issues.apache.org/jira/browse/SENTRY-1428
>
>
> Repository: sentry
>
>
> Description
> -------
>
> - Added LeaderStatusMonitor to HMSFollower
> - Minor cleanup of HMSFollower class
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java f3cefd6a232bfb91db28f04bebcc98ab3c1ca658
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java a89d3f6c52e3e6f23794f3a8998ea8a2236886cb
>
> Diff: https://reviews.apache.org/r/55595/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>