You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Hector Acosta (Code Review)" <ge...@cloudera.org> on 2019/03/20 17:14:22 UTC

[native-toolchain-CR] Add documentation for docker-based toolchain builds

Hello Thomas Marshall, Laszlo Gaal, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12810

to look at the new patch set (#2).

Change subject: Add documentation for docker-based toolchain builds
......................................................................

Add documentation for docker-based toolchain builds

This commit adds basic documentation with regard to docker-based
toolchain builds. It briefly outlines how to build images and how to use
them to build the toolchain. I also added the ability to fetch images
from a docker registry. And fixed an 'undefined' variable problem with
docker-based builds.

Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170
---
M Makefile
A docker/README.md
M functions.sh
3 files changed, 52 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/10/12810/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170
Gerrit-Change-Number: 12810
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>