[commons-compress] 05/05: hasRemaining may be faster that actually counting elements

[bo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

bodewig pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git

commit 34c3311d406c648a7b6ada342bf4c294fd81a6ee
Author: Stefan Bodewig <bo...@apache.org>
AuthorDate: Fri Aug 23 17:12:01 2019 +0200

    hasRemaining may be faster that actually counting elements
---
 .../java/org/apache/commons/compress/archivers/zip/NioZipEncoding.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/commons/compress/archivers/zip/NioZipEncoding.java b/src/main/java/org/apache/commons/compress/archivers/zip/NioZipEncoding.java
index 4ce9c20..401f9fa 100644
--- a/src/main/java/org/apache/commons/compress/archivers/zip/NioZipEncoding.java
+++ b/src/main/java/org/apache/commons/compress/archivers/zip/NioZipEncoding.java
@@ -82,7 +82,7 @@ class NioZipEncoding implements ZipEncoding, CharsetAccessor {
         CharBuffer tmp = null;
         ByteBuffer out = ByteBuffer.allocate(estimateInitialBufferSize(enc, cb.remaining()));
 
-        while (cb.remaining() > 0) {
+        while (cb.hasRemaining()) {
             final CoderResult res = enc.encode(cb, out, false);
 
             if (res.isUnmappable() || res.isMalformed()) {