You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Brian Behlendorf <br...@hyperreal.org> on 1998/05/29 02:25:43 UTC

Re: [PATCH] fix a few warnings in OS/2 build (was Re: const stuff)

At 07:20 PM 5/25/98 +1000, Brian Havard wrote:
>Using "-Wall -Wshadow -Wmissing-prototypes" I get quite a few warnings in
the 
>OS/2 build. The patch below fixes most of the OS/2 specific ones 

Okay, I've committed them.

>but there are 
>a few general ones I'd expect to show up on other platforms:
>
>http_log.c: In function `ap_open_piped_log':
>http_log.c:656: warning: passing arg 2 of `ap_spawn_child_err' from
incompatible pointer type

Hmm, I wasn't seeing this, but this should clearly be fixed (so I have)

>util_script.c: In function `ap_send_size':
>util_script.c:550: warning: int format, long int arg (arg 3)
>util_script.c:554: warning: int format, long int arg (arg 3)
>mod_autoindex.c: In function `make_autoindex_entry':
>mod_autoindex.c:716: warning: int format, long int arg (arg 4)
>
>The "int format, long int arg" warnings are from feeding a size_t to %d but 
>for me size_t is an unsigned long. Would an int cast be appropriate?

*shrug*

	Brian


--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
pure chewing satisfaction                                  brian@apache.org
                                                        brian@hyperreal.org