[GitHub] [airflow] BobDu commented on pull request #25219: Update statsd-exporter setup

[GitBox <gi...@apache.org>]

BobDu commented on PR #25219:
URL: https://github.com/apache/airflow/pull/25219#issuecomment-1255118674

   I had the same problem
   When I try to modify some default mapping configuration, if just add a new mapping item, using extraMapping can fully needs,
   but, if add it conflicts with the default mapping item, custom configuration does not take effect.
   
   
   Because now default configuration always takes higher priority.
   ```
     mappings.yml: |-
   {{ .Files.Get "dockerfiles/statsd-exporter/mappings.yml" | indent 4 }}
   {{ toYaml .Values.statsd.extraMappings | indent 6 }}
   {{- end }}
   ```
   
   There are only two options for it.
   1. fork and change the helm chart
   2. custom build my statsd expoorter image with my mappings file.
   both bad practice.
   
   I believe this PR can reslove this probelm.
   But, By reading reviews comment, I realized because this want to add some new metrics mapping,
   reviewers worry will break backwards compatibility.
   So, it needs to be more carefully justified.
   
   I'm trying to split it into two steps.
   First, only provided a optional choose: overideMapping, no change an default behavior, it should be easier and faster to merge.
   Then, we continue to carefully add metrics in this PR.
   
   So, I create a new PR #26598 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org