[jira] [Comment Edited] (TOMEE-2125) Datasource config: MaxWait, timeBetweenEvictionRunsMillis and MinEvictableIdleTimeMillis are ignored

["Sylvain Berthouzoz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TOMEE-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166660#comment-16166660 ] 

Sylvain Berthouzoz edited comment on TOMEE-2125 at 9/14/17 5:33 PM:
--------------------------------------------------------------------

By the way, the three Duration parameters of the method {{create(String name, boolean configuredManaged, Class impl, String definition, Duration maxWaitTime, Duration timeBetweenEvictionRuns, Duration minEvictableIdleTime, boolean useAlternativeDriver)}} (still in the {{DataSourceFactory}}class)
* Duration maxWaitTime, 
* Duration timeBetweenEvictionRuns, 
* Duration minEvictableIdleTime

were always null when I tried to debug this. But I didn't find where there should have been set.


was (Author: sberthouzoz):
By the way, the three Duration parameters of the method {{create(String name, boolean configuredManaged, Class impl, String definition, Duration maxWaitTime, Duration timeBetweenEvictionRuns, Duration minEvictableIdleTime, boolean useAlternativeDriver)}} (still in the {{DataSourceFactory}}class)
* Duration maxWaitTime, 
* Duration timeBetweenEvictionRuns, 
* Duration minEvictableIdleTime
were always null when I tried to debug this. But I didn't find where there should have been set.

> Datasource config: MaxWait, timeBetweenEvictionRunsMillis and MinEvictableIdleTimeMillis are ignored
> ----------------------------------------------------------------------------------------------------
>
>                 Key: TOMEE-2125
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2125
>             Project: TomEE
>          Issue Type: Bug
>          Components: TomEE Core Server
>    Affects Versions: 7.0.3
>            Reporter: Sylvain Berthouzoz
>              Labels: configuration
>
> MaxWait Property is ignored because it will always be removed.
> As example, this is my configuration in tomee.xml
> {code:xml}
> <Resource id="database" type="javax.sql.DataSource">
>         JdbcDriver = com.mysql.jdbc.Driver
>         JdbcUrl = jdbc:mysql://localhost:3306/dbname?useSSL=false
>         UserName = username
>         Password = somepw
>         MaxActive = 20
>         MaxIdle = 20
>         MinIdle = 2
>         InitialSize = 2
>         MaxWait = 5000
>         TestOnBorrow = true
>         ValidationQuery = select 1
>         timeBetweenEvictionRuns = 7200000
>         MinEvictableIdleTimeMillis = 7200000
>         TestWhileIdle = true
>     </Resource>
> {code}
> The error is in the file {{openejb-core-7.0.3.jar!\org\apache\openejb\resource\jdbc\DataSourceFactory}} where it looks for values, instead of looking for key (line 356):
> {code:java}
> private static void convert(Properties properties, Duration duration, String key, String oldKey) {
>         properties.remove(key);
>         if(!properties.contains(oldKey)) {
>             properties.remove(oldKey);
>             if(duration != null) {
>                 if(duration.getUnit() == null) {
>                     duration.setUnit(TimeUnit.MILLISECONDS);
>                 }
>                 long milliseconds = TimeUnit.MILLISECONDS.convert(duration.getTime(), duration.getUnit());
>                 properties.put(oldKey, String.valueOf(milliseconds));
>             }
>         }
>     }
> {code}
> {{properties.contains(oldKey)}} should be replaced by {{properties.containsKey(oldKey)}}
> So all properties which uses this convert method are ignored:
> {code:java}
> convert(properties, maxWaitTime, "maxWaitTime", "maxWait");
> convert(properties, timeBetweenEvictionRuns, "timeBetweenEvictionRuns", "timeBetweenEvictionRunsMillis");
> convert(properties, minEvictableIdleTime, "minEvictableIdleTime", "minEvictableIdleTimeMillis");
> {code}
> ----
> *WORKAROUD*
> To avoid that, it is possible to have fake properties in tomee.xml with the ignored property as value (see the ignoreMe properties at the end):
> {code:xml}
>     <Resource id="smclient" type="javax.sql.DataSource">
>         JdbcDriver = com.mysql.jdbc.Driver
>         JdbcUrl = jdbc:mysql://localhost:3306/dbname?useSSL=false
>         UserName = username
>         Password = somepw
>         MaxActive = 20
>         MaxIdle = 20
>         MinIdle = 2
>         InitialSize = 2
>         MaxWait = 5000
>         TestOnBorrow = true
>         ValidationQuery = select 1
>         timeBetweenEvictionRunsMillis = 7200000
>         MinEvictableIdleTimeMillis = 7200000
>         TestWhileIdle = true
>         ignoreMe = maxWait
>         ignoreMe2 = timeBetweenEvictionRunsMillis
>         ignoreMe3 = minEvictableIdleTimeMillis
>     </Resource>
> {code}
> Then the values are correctly set to the datasources (verified with visualvm in the datasource MBean)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)