You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by GitBox <gi...@apache.org> on 2022/01/12 07:27:37 UTC

[GitHub] [opennlp] kinow opened a new pull request #401: OPENNLP-1352: Replace Travis CI by GH Actions

kinow opened a new pull request #401:
URL: https://github.com/apache/opennlp/pull/401


   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
   - [x] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GH Actions for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [opennlp] kinow commented on pull request #401: OPENNLP-1352: Replace Travis CI by GH Actions

Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #401:
URL: https://github.com/apache/opennlp/pull/401#issuecomment-1012677582


   Thanks @jzonthemtn !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [opennlp] kinow commented on pull request #401: OPENNLP-1352: Replace Travis CI by GH Actions

Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #401:
URL: https://github.com/apache/opennlp/pull/401#issuecomment-1010769022


   This is now ready for review. To review, one can look at the latest build on my fork where the action has already run: https://github.com/kinow/opennlp/actions/runs/1686590266
   
   ![image](https://user-images.githubusercontent.com/304786/149090969-8677452e-cb75-4e41-806a-9b1017f8d809.png)
   
   Note that the coverage is failing, but not failing the build. This is the exact same behaviour from master. To confirm, you can open a recent pull request (like the ONNX one), then go to checks, expand and click. There, find the link to the build, and look at the raw logs.
   
   It will contain something similar to this screenshot:
   
   ![image](https://user-images.githubusercontent.com/304786/149091150-a62bed26-00b6-4221-9b9c-78116a7556ab.png)
   
   The time to start and complete the build was **a lot** faster than Travis CI recent builds :+1: 
   
   Cheers,
   Bruno


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [opennlp] kinow merged pull request #401: OPENNLP-1352: Replace Travis CI by GH Actions

Posted by GitBox <gi...@apache.org>.
kinow merged pull request #401:
URL: https://github.com/apache/opennlp/pull/401


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org