You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/01/04 18:14:03 UTC

[GitHub] [beam] omarismail94 commented on a change in pull request #13410: [BEAM-11327] Replace Charset.defaultCharset() with StandardCharsets.UTF_8

omarismail94 commented on a change in pull request #13410:
URL: https://github.com/apache/beam/pull/13410#discussion_r551482024



##########
File path: sdks/java/build-tools/src/main/resources/beam/checkstyle.xml
##########
@@ -119,6 +119,14 @@ page at http://checkstyle.sourceforge.net/config.html -->
       <property name="message" value="You are using raw guava, please use vendored guava classes."/>
     </module>
 
+    <!-- Forbid use of Charset.defaultCharset()-->
+    <module name="RegexpSinglelineJava">
+      <property name="id" value="ForbidCharset"/>

Review comment:
       Updated, thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org