You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Perdjesk (via GitHub)" <gi...@apache.org> on 2023/06/28 11:48:47 UTC
[GitHub] [lucene] Perdjesk opened a new pull request, #12402: Correct Javadocs using SimpleBindings
Perdjesk opened a new pull request, #12402:
URL: https://github.com/apache/lucene/pull/12402
### Description
Correct Javadocs still referring to removed API: SimpleBindings#add(SortField).
https://github.com/apache/lucene/commit/5eb117f561ab691f34409943ae1f85781735f8e0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] romseygeek merged pull request #12402: Correct Javadocs using SimpleBindings
Posted by "romseygeek (via GitHub)" <gi...@apache.org>.
romseygeek merged PR #12402:
URL: https://github.com/apache/lucene/pull/12402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] Perdjesk commented on a diff in pull request #12402: Correct Javadocs using SimpleBindings
Posted by "Perdjesk (via GitHub)" <gi...@apache.org>.
Perdjesk commented on code in PR #12402:
URL: https://github.com/apache/lucene/pull/12402#discussion_r1245128216
##########
lucene/core/src/java/org/apache/lucene/search/package-info.java:
##########
@@ -303,8 +303,8 @@
*
* // SimpleBindings just maps variables to SortField instances
Review Comment:
Missed the edit in the comment referring to SortField.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] Perdjesk commented on a diff in pull request #12402: Correct Javadocs using SimpleBindings
Posted by "Perdjesk (via GitHub)" <gi...@apache.org>.
Perdjesk commented on code in PR #12402:
URL: https://github.com/apache/lucene/pull/12402#discussion_r1245131114
##########
lucene/core/src/java/org/apache/lucene/search/package-info.java:
##########
@@ -303,8 +303,8 @@
*
* // SimpleBindings just maps variables to SortField instances
Review Comment:
Fixed with https://github.com/apache/lucene/pull/12402/commits/b3feee3acf6c68ebdfbf6da72ba3a4592cfd98df
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org