[GitHub] [geode-native] gaussianrecurrence commented on pull request #660: GEODE-8553: Fix inter-locks in ThinClientLocator

[GitBox <gi...@apache.org>]

gaussianrecurrence commented on pull request #660:
URL: https://github.com/apache/geode-native/pull/660#issuecomment-721399787


   Ok @pdxcodemonkey and @pivotal-jbarrett I think I came up with an integration test for this change. It works as follows:
      * Set 5s connect-timeout.
      * Deploy 1 locator.
      * Add 1 non-existent locator to the pool.
      * Send 64 concurrent requests to get the server list.
      * By probability if there are no interlocks ~50%+-E% of the requests should
        have completed in a brief period of time.
      * Note that E% is the error allowance percentage, which is set to 10%.
      * Therefore a 10 seconds timeout is set in order to reach the request
        completed treshold.
      * Test passes if the number of completed requests before the timeout was
        greater or equal to the thresholds, otherwise it fails.
   
   It does not cover everything, but I'd would appreciate your feedback in order to see If I am in the right direction. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org