[jira] [Comment Edited] (CALCITE-1834) Implement precedence list for Array and Multiset

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070700#comment-16070700 ] 

Julian Hyde edited comment on CALCITE-1834 at 6/30/17 8:50 PM:
---------------------------------------------------------------

I made a couple of changes:
* Removed the type factory from the function. Parameters are supposed to be lambdas that create types when given a type factory.
* I converted a couple of {{assert}} statements to {{if ... throw}}. Otherwise the test would fail if asserts were disabled.

Looks good, nice work, testing now, will commit soon.


was (Author: julianhyde):
I made a couple of changes:
* Removed the type factory from the function. Parameters are supposed to be lambdas that create types when given a type factory.
* I converted a couple of {{assert}}s to {{if ... throw}}. Otherwise the test would fail if asserts were disabled.

Looks good, nice work, testing now, will commit soon.

> Implement precedence list for Array and Multiset
> ------------------------------------------------
>
>                 Key: CALCITE-1834
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1834
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Ankit Singhal
>            Assignee: Julian Hyde
>
> Arrays and Multisets can have precedence according to the precedence of its component type.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)