You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/03 13:05:56 UTC

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request #5146: arch/arm/samv7: rework SAMv7 timer counter implementation

pkarashchenko opened a new pull request #5146:
URL: https://github.com/apache/incubator-nuttx/pull/5146


   ## Summary
   There are two issues that are addressed with ths change:
    - According to SAM E70/S70/V70/V71 Family datasheet the
      timer counter channels are 16-bit so timer counter
      value should be changed from uint32_t to uint16_t
    - The interrupt handling for timer counter channels can
      be simplified
   
   ## Impact
   SAMv7 based devices
   
   ## Testing
   Pass CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5146: arch/arm/samv7: rework SAMv7 timer counter implementation

Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #5146:
URL: https://github.com/apache/incubator-nuttx/pull/5146#discussion_r777522118



##########
File path: arch/arm/src/samv7/sam_freerun.c
##########
@@ -220,8 +220,8 @@ int sam_freerun_initialize(struct sam_freerun_s *freerun, int chan,
 int sam_freerun_counter(struct sam_freerun_s *freerun, struct timespec *ts)
 {
   uint64_t usec;
-  uint32_t counter;
-  uint32_t verify;
+  uint16_t counter;

Review comment:
       @pkarashchenko since you are changing "counter" and "verify" to uint16_t I suggest you to move down after the uint32_t variables. It is not a requirement, but a good practice to avoid alignment issues.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko edited a comment on pull request #5146: arch/arm/samv7: rework SAMv7 timer counter implementation

Posted by GitBox <gi...@apache.org>.
pkarashchenko edited a comment on pull request #5146:
URL: https://github.com/apache/incubator-nuttx/pull/5146#issuecomment-1008135907


   @nandojve could you please review these changes?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5146: arch/arm/samv7: rework SAMv7 timer counter implementation

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5146:
URL: https://github.com/apache/incubator-nuttx/pull/5146#issuecomment-1008135907


   @nandojve could you please review this changes?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5146: arch/arm/samv7: rework SAMv7 timer counter implementation

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5146:
URL: https://github.com/apache/incubator-nuttx/pull/5146#discussion_r777921360



##########
File path: arch/arm/src/samv7/sam_freerun.c
##########
@@ -220,8 +220,8 @@ int sam_freerun_initialize(struct sam_freerun_s *freerun, int chan,
 int sam_freerun_counter(struct sam_freerun_s *freerun, struct timespec *ts)
 {
   uint64_t usec;
-  uint32_t counter;
-  uint32_t verify;
+  uint16_t counter;

Review comment:
       In this particular case it does not matter because 2 of uint16_t are exactly uint32_t size, but I will move.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5146: arch/arm/samv7: rework SAMv7 timer counter implementation

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5146:
URL: https://github.com/apache/incubator-nuttx/pull/5146


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org