You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2017/03/27 12:02:40 UTC
[GitHub] tinkerpop pull request #585: TINEKRPOP-1654 tp32 Jackson Version Bump
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/585
TINEKRPOP-1654 tp32 Jackson Version Bump
This is the follow on to #579 - i don't think it needs an specific vote. There were a compilation problem that that needed resolution as we used a deprecated method that jackson has since dropped. @newkek could you please have a look at this change - does it look ok to you?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1654-tp32
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/585.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #585
----
commit 2aa550e32bec2b63a6f0c8f292ad1d04b605f9a1
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2017-03-23T12:58:37Z
TINKERPOP-1654 Bumped to Jackson 2.8.7
commit 7db459b0b839afe3a5a746de2878c31db4eceb96
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2017-03-27T11:00:30Z
Merge branch 'TINKERPOP-1654' into TINKERPOP-1654-tp32
commit 380646cf1df466925af8ed830fba8858cb8c49b3
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2017-03-27T11:56:44Z
TINKERPOP-1654 Fixed compilation errors after jackson version bump
Jackson removed a deprecated method. Called the replacement method instead.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #585: TINEKRPOP-1654 tp32 Bumped to Jackson 2.8.7
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/585
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #585: TINEKRPOP-1654 tp32 Bumped to Jackson 2.8.7
Posted by newkek <gi...@git.apache.org>.
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/585
@spmallette I actually had a fix slightly different in mind, I just tested and it works and the tests pass, mind if I use that different solution?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #585: TINEKRPOP-1654 tp32 Bumped to Jackson 2.8.7
Posted by newkek <gi...@git.apache.org>.
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/585
Cool, thanks - #586
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #585: TINEKRPOP-1654 tp32 Bumped to Jackson 2.8.7
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/585
sure - i just went with what i thought was happening already. if there's a better way, great! it's why i asked for you to take a look :smile: will you issue a PR to this branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---