You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/02/05 17:46:40 UTC
Review Request 65506: Used `dispatch` instead of `defer` for offer
callbacks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65506/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Jie Yu.
Bugs: MESOS-8524
https://issues.apache.org/jira/browse/MESOS-8524
Repository: mesos
Description
-------
This patch modifies the callbacks passed to the allocator to make sure
they are dispatched instead of deferred. This is done to make sure
that if another request potentially changing allocator state arrives
after the allocator has invoked the callback, the callback is
processed first. Otherwise we risk running into races on allocator
state.
Diffs
-----
src/master/master.cpp cc2685a6bc14103c639ce776cf1c912361e93381
Diff: https://reviews.apache.org/r/65506/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 65506: Used `dispatch` instead of `defer` for offer
callbacks.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65506/#review196816
-----------------------------------------------------------
This looks like a no-op..? Defer is a dispatch functor, so it looks equivalent to your dispatch functor.
- Benjamin Mahler
On Feb. 5, 2018, 5:46 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65506/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 5:46 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Jie Yu.
>
>
> Bugs: MESOS-8524
> https://issues.apache.org/jira/browse/MESOS-8524
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch modifies the callbacks passed to the allocator to make sure
> they are dispatched instead of deferred. This is done to make sure
> that if another request potentially changing allocator state arrives
> after the allocator has invoked the callback, the callback is
> processed first. Otherwise we risk running into races on allocator
> state.
>
>
> Diffs
> -----
>
> src/master/master.cpp cc2685a6bc14103c639ce776cf1c912361e93381
>
>
> Diff: https://reviews.apache.org/r/65506/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65506: Used `dispatch` instead of `defer` for offer
callbacks.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65506/#review196820
-----------------------------------------------------------
PASS: Mesos patch 65506 was successfully built and tested.
Reviews applied: `['65482', '65506']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65506
- Mesos Reviewbot Windows
On Feb. 5, 2018, 5:46 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65506/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 5:46 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Jie Yu.
>
>
> Bugs: MESOS-8524
> https://issues.apache.org/jira/browse/MESOS-8524
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch modifies the callbacks passed to the allocator to make sure
> they are dispatched instead of deferred. This is done to make sure
> that if another request potentially changing allocator state arrives
> after the allocator has invoked the callback, the callback is
> processed first. Otherwise we risk running into races on allocator
> state.
>
>
> Diffs
> -----
>
> src/master/master.cpp cc2685a6bc14103c639ce776cf1c912361e93381
>
>
> Diff: https://reviews.apache.org/r/65506/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>