You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "busgo (via GitHub)" <gi...@apache.org> on 2023/06/13 06:54:29 UTC
[GitHub] [superset] busgo opened a new pull request, #24376: presto ssl
busgo opened a new pull request, #24376:
URL: https://github.com/apache/superset/pull/24376
presto ssl
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #24376: presto ssl
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #24376:
URL: https://github.com/apache/superset/pull/24376#issuecomment-1588874113
@busgo please provide a full sentence under the "SUMMARY" title in the PR description of what this PR is doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: add presto ssl config details [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #24376:
URL: https://github.com/apache/superset/pull/24376#issuecomment-1922487255
Closing this one due to inactivity, and I've rebooted it here: https://github.com/apache/superset/pull/26986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: add presto ssl config details [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #24376:
URL: https://github.com/apache/superset/pull/24376#discussion_r1383813349
##########
docs/docs/databases/presto.mdx:
##########
@@ -35,3 +35,14 @@ datasource. If you’re using an older version of Presto, you can configure it i
"version": "0.123"
}
```
+
+SSL Secure extra add json config to extra connection information.
+
+```
+ {
+ "connect_args":
+ {"protocol": "https",
+ "requests_kwargs":{"verify":false}
+ }
Review Comment:
```suggestion
}
```
##########
docs/docs/databases/presto.mdx:
##########
@@ -35,3 +35,14 @@ datasource. If you’re using an older version of Presto, you can configure it i
"version": "0.123"
}
```
+
+SSL Secure extra add json config to extra connection information.
+
+```
+ {
+ "connect_args":
+ {"protocol": "https",
+ "requests_kwargs":{"verify":false}
+ }
Review Comment:
removing trailing whitespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: add presto ssl config details [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #24376:
URL: https://github.com/apache/superset/pull/24376#issuecomment-1922487568
Thanks @busgo for taking this on!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #24376: docs: add presto ssl config details
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #24376:
URL: https://github.com/apache/superset/pull/24376#discussion_r1228412834
##########
docs/docs/databases/presto.mdx:
##########
@@ -35,3 +35,16 @@ datasource. If you’re using an older version of Presto, you can configure it i
"version": "0.123"
}
```
+
+SSL Secure extra add json config to extra connection information.
+
+```
+ {
+ "connect_args":
+ {"protocol": "https",
+ "requests_kwargs":{"verify":false}
+ }
+}
+```
+
+
Review Comment:
You need to remove this trailing whitespace:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] busgo commented on pull request #24376: presto ssl
Posted by "busgo (via GitHub)" <gi...@apache.org>.
busgo commented on PR #24376:
URL: https://github.com/apache/superset/pull/24376#issuecomment-1588902872
> @busgo please provide a full sentence under the "SUMMARY" title in the PR description of what this PR is doing.
ok! has add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: add presto ssl config details [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #24376: docs: add presto ssl config details
URL: https://github.com/apache/superset/pull/24376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org