You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2023/01/09 19:13:13 UTC
[GitHub] [datasketches-cpp] jbapple opened a new pull request, #327: Explicitly cast constant uint64_ts that lose precision.
jbapple opened a new pull request, #327:
URL: https://github.com/apache/datasketches-cpp/pull/327
In clang-16, there are warnings like this upon build:
warning: implicit conversion from 'const uint64_t' (aka 'const
unsigned long') to 'double' changes value from 9223372036854775807
to 9223372036854775808 [-Wimplicit-const-int-float-conversion]
Explicit casting fixes those warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] coveralls commented on pull request #327: Explicitly cast constant uint64_ts that lose precision.
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #327:
URL: https://github.com/apache/datasketches-cpp/pull/327#issuecomment-1376159312
## Pull Request Test Coverage Report for [Build 3876955097](https://coveralls.io/builds/55775389)
* **3** of **3** **(100.0%)** changed or added relevant lines in **2** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.002%**) to **93.871%**
---
| Totals | [](https://coveralls.io/builds/55775389) |
| :-- | --: |
| Change from base [Build 3876432800](https://coveralls.io/builds/55772975): | 0.002% |
| Covered Lines: | 2328 |
| Relevant Lines: | 2480 |
---
##### 💛 - [Coveralls](https://coveralls.io)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] AlexanderSaydakov merged pull request #327: Explicitly cast constant uint64_ts that lose precision.
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov merged PR #327:
URL: https://github.com/apache/datasketches-cpp/pull/327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org