You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Alberto Bueno (JIRA)" <ji...@apache.org> on 2006/11/10 23:15:37 UTC
[jira] Created: (WICKET-41) Problem in generation of the html code
of the page
Problem in generation of the html code of the page
--------------------------------------------------
Key: WICKET-41
URL: http://issues.apache.org/jira/browse/WICKET-41
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 2.0
Reporter: Alberto Bueno
When we create a page, the page generates this html code:
<script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
/*-->]]>*/</script>
Now, we add a button in the page (a very simple page):
public class Index extends QuickStartPage
{
public Index(final PageParameters parameters)
{
Form form = new Form(this, "form");
new Button(form, "button"){
@Override
public void onSubmit()
{
// TODO Auto-generated method stub
String p = "";
}
};
}
}
And when we click the button, in the generation of the page we have the code duplicated:
<script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
/*-->]]>*/</script>
<script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
/*-->]]>*/</script>
And if we continue clicking the button, the page continues duplicating the code...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-41) Problem in generation of the html
code of the page
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491763 ]
Jean-Baptiste Quenot commented on WICKET-41:
--------------------------------------------
I guess we can close this one now?
> Problem in generation of the html code of the page
> --------------------------------------------------
>
> Key: WICKET-41
> URL: https://issues.apache.org/jira/browse/WICKET-41
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 2.0
> Reporter: Alberto Bueno
> Assigned To: Matej Knopp
> Fix For: 2.0
>
>
> When we create a page, the page generates this html code:
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> Now, we add a button in the page (a very simple page):
> public class Index extends QuickStartPage
> {
> public Index(final PageParameters parameters)
> {
> Form form = new Form(this, "form");
> new Button(form, "button"){
> @Override
> public void onSubmit()
> {
> // TODO Auto-generated method stub
> String p = "";
> }
> };
> }
> }
> And when we click the button, in the generation of the page we have the code duplicated:
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> And if we continue clicking the button, the page continues duplicating the code...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-41) Problem in generation of the html code
of the page
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eelco Hillenius resolved WICKET-41.
-----------------------------------
Resolution: Fixed
> Problem in generation of the html code of the page
> --------------------------------------------------
>
> Key: WICKET-41
> URL: https://issues.apache.org/jira/browse/WICKET-41
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 2.0
> Reporter: Alberto Bueno
> Assigned To: Matej Knopp
> Fix For: 2.0
>
>
> When we create a page, the page generates this html code:
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> Now, we add a button in the page (a very simple page):
> public class Index extends QuickStartPage
> {
> public Index(final PageParameters parameters)
> {
> Form form = new Form(this, "form");
> new Button(form, "button"){
> @Override
> public void onSubmit()
> {
> // TODO Auto-generated method stub
> String p = "";
> }
> };
> }
> }
> And when we click the button, in the generation of the page we have the code duplicated:
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> And if we continue clicking the button, the page continues duplicating the code...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-41) Problem in generation of the html
code of the page
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/WICKET-41?page=comments#action_12450081 ]
Igor Vaynberg commented on WICKET-41:
-------------------------------------
if you dont filter solely on id you can end up with a bunch of script tags that have the same id but different content - that is weird. imho as well.
as for why its not fltering that is for you to debug :)
> Problem in generation of the html code of the page
> --------------------------------------------------
>
> Key: WICKET-41
> URL: http://issues.apache.org/jira/browse/WICKET-41
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 2.0
> Reporter: Alberto Bueno
> Assigned To: Matej Knopp
>
> When we create a page, the page generates this html code:
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> Now, we add a button in the page (a very simple page):
> public class Index extends QuickStartPage
> {
> public Index(final PageParameters parameters)
> {
> Form form = new Form(this, "form");
> new Button(form, "button"){
> @Override
> public void onSubmit()
> {
> // TODO Auto-generated method stub
> String p = "";
> }
> };
> }
> }
> And when we click the button, in the generation of the page we have the code duplicated:
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> And if we continue clicking the button, the page continues duplicating the code...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-41) Problem in generation of the html
code of the page
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491822 ]
Matej Knopp commented on WICKET-41:
-----------------------------------
i think so.
> Problem in generation of the html code of the page
> --------------------------------------------------
>
> Key: WICKET-41
> URL: https://issues.apache.org/jira/browse/WICKET-41
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 2.0
> Reporter: Alberto Bueno
> Assigned To: Matej Knopp
> Fix For: 2.0
>
>
> When we create a page, the page generates this html code:
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> Now, we add a button in the page (a very simple page):
> public class Index extends QuickStartPage
> {
> public Index(final PageParameters parameters)
> {
> Form form = new Form(this, "form");
> new Button(form, "button"){
> @Override
> public void onSubmit()
> {
> // TODO Auto-generated method stub
> String p = "";
> }
> };
> }
> }
> And when we click the button, in the generation of the page we have the code duplicated:
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> And if we continue clicking the button, the page continues duplicating the code...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-41) Problem in generation of the html
code of the page
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/WICKET-41?page=comments#action_12450067 ]
Matej Knopp commented on WICKET-41:
-----------------------------------
I don't get it. IMHO it should only filter when the id and body is equal. In the duplicated code it seems that the content is equal, and there's no id, so why is that not filtered out?
> Problem in generation of the html code of the page
> --------------------------------------------------
>
> Key: WICKET-41
> URL: http://issues.apache.org/jira/browse/WICKET-41
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 2.0
> Reporter: Alberto Bueno
> Assigned To: Matej Knopp
>
> When we create a page, the page generates this html code:
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> Now, we add a button in the page (a very simple page):
> public class Index extends QuickStartPage
> {
> public Index(final PageParameters parameters)
> {
> Form form = new Form(this, "form");
> new Button(form, "button"){
> @Override
> public void onSubmit()
> {
> // TODO Auto-generated method stub
> String p = "";
> }
> };
> }
> }
> And when we click the button, in the generation of the page we have the code duplicated:
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> And if we continue clicking the button, the page continues duplicating the code...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-41) Problem in generation of the html
code of the page
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/WICKET-41?page=comments#action_12450084 ]
Matej Knopp commented on WICKET-41:
-----------------------------------
I dunno. I think the content is more important that the ID. If the scripts are different, it means that they do different things. So perhaps we shouldn't rely on id only.
> Problem in generation of the html code of the page
> --------------------------------------------------
>
> Key: WICKET-41
> URL: http://issues.apache.org/jira/browse/WICKET-41
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 2.0
> Reporter: Alberto Bueno
> Assigned To: Matej Knopp
>
> When we create a page, the page generates this html code:
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> Now, we add a button in the page (a very simple page):
> public class Index extends QuickStartPage
> {
> public Index(final PageParameters parameters)
> {
> Form form = new Form(this, "form");
> new Button(form, "button"){
> @Override
> public void onSubmit()
> {
> // TODO Auto-generated method stub
> String p = "";
> }
> };
> }
> }
> And when we click the button, in the generation of the page we have the code duplicated:
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> And if we continue clicking the button, the page continues duplicating the code...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-41) Problem in generation of the html code
of the page
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eelco Hillenius updated WICKET-41:
----------------------------------
Fix Version/s: 2.0
> Problem in generation of the html code of the page
> --------------------------------------------------
>
> Key: WICKET-41
> URL: https://issues.apache.org/jira/browse/WICKET-41
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 2.0
> Reporter: Alberto Bueno
> Assigned To: Matej Knopp
> Fix For: 2.0
>
>
> When we create a page, the page generates this html code:
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> Now, we add a button in the page (a very simple page):
> public class Index extends QuickStartPage
> {
> public Index(final PageParameters parameters)
> {
> Form form = new Form(this, "form");
> new Button(form, "button"){
> @Override
> public void onSubmit()
> {
> // TODO Auto-generated method stub
> String p = "";
> }
> };
> }
> }
> And when we click the button, in the generation of the page we have the code duplicated:
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> And if we continue clicking the button, the page continues duplicating the code...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-41) Problem in generation of the html code
of the page
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/WICKET-41?page=all ]
Igor Vaynberg reassigned WICKET-41:
-----------------------------------
Assignee: Matej Knopp
looks like HeaderResponse is not filtering duplicates.
also need to make sure methods like (CharSequeunce script, String id) filter exclusively on id and discregard value of script. right now looks like you are sticking both into an array so both are used for comparison. so ["foo","id"] and ["bar","id"] will result in both foo and bar rendering which is wrong.
> Problem in generation of the html code of the page
> --------------------------------------------------
>
> Key: WICKET-41
> URL: http://issues.apache.org/jira/browse/WICKET-41
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 2.0
> Reporter: Alberto Bueno
> Assigned To: Matej Knopp
>
> When we create a page, the page generates this html code:
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> Now, we add a button in the page (a very simple page):
> public class Index extends QuickStartPage
> {
> public Index(final PageParameters parameters)
> {
> Form form = new Form(this, "form");
> new Button(form, "button"){
> @Override
> public void onSubmit()
> {
> // TODO Auto-generated method stub
> String p = "";
> }
> };
> }
> }
> And when we click the button, in the generation of the page we have the code duplicated:
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> And if we continue clicking the button, the page continues duplicating the code...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-41) Problem in generation of the html
code of the page
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479918 ]
Matej Knopp commented on WICKET-41:
-----------------------------------
This looks to be caused by the fact that i didn't realize that not everything that implements CharSequence compares the content. Should be fixed, can you please try latest 1.x / trunk?
> Problem in generation of the html code of the page
> --------------------------------------------------
>
> Key: WICKET-41
> URL: https://issues.apache.org/jira/browse/WICKET-41
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 2.0
> Reporter: Alberto Bueno
> Assigned To: Matej Knopp
> Fix For: 2.0
>
>
> When we create a page, the page generates this html code:
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> Now, we add a button in the page (a very simple page):
> public class Index extends QuickStartPage
> {
> public Index(final PageParameters parameters)
> {
> Form form = new Form(this, "form");
> new Button(form, "button"){
> @Override
> public void onSubmit()
> {
> // TODO Auto-generated method stub
> String p = "";
> }
> };
> }
> }
> And when we click the button, in the generation of the page we have the code duplicated:
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> <script type="text/javascript" ><!--/*--><![CDATA[/*><!--*/
> if (window.name=='') { window.location="/quickstart/app?wicket:interface=:1::INewBrowserWindowListener"; }
> /*-->]]>*/</script>
> And if we continue clicking the button, the page continues duplicating the code...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.