[GitHub] [flink] tillrohrmann commented on a change in pull request #12981: [FLINK-18581] Do not run GC phantom cleaners for Java < 8u72

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #12981:
URL: https://github.com/apache/flink/pull/12981#discussion_r460147299



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/memory/UnsafeMemoryBudget.java
##########
@@ -147,8 +147,10 @@ void reserveMemory(long size, int maxSleeps) throws MemoryReservationException {
 			}
 
 			// no luck
-			throw new MemoryReservationException(
-				String.format("Could not allocate %d bytes, only %d bytes are remaining", size, availableOrReserved));
+			throw new MemoryReservationException(String.format(
+				"Could not allocate %d bytes, only %d bytes are remaining, try to upgrade to Java 8u72 or higher",

Review comment:
       Yes adding a bit more context for why to upgrade would be helpful. E.g. "This usually indicates that you are requesting more memory than you have reserved. However, when running an old JVM version it can also be caused by slow garbage collection. Try to upgrade to Java 8u72 or higher if running on an old Java version.".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org