[GitHub] [spark] AngersZhuuuu commented on a change in pull request #35594: [SPARK-38270][SQL] Spark SQL CLI's AM should keep same exit code with client side

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #35594:
URL: https://github.com/apache/spark/pull/35594#discussion_r811732308



##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -2059,7 +2059,9 @@ class SparkContext(config: SparkConf) extends Logging {
   /**
    * Shut down the SparkContext.
    */
-  def stop(): Unit = {
+  def stop(): Unit = stop(0)
+
+  def stop(exitCode: Int): Unit = {

Review comment:
       > This is a public API and we need to document it properly.
   
   Updated




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org