You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "CRZbulabula (via GitHub)" <gi...@apache.org> on 2026/07/30 04:15:59 UTC
[PR] Disable multi-node REMOVE statements [iotdb]
CRZbulabula opened a new pull request, #18360:
URL: https://github.com/apache/iotdb/pull/18360
## Description
This PR restricts cluster-node removal statements to a single node ID in both SQL dialects.
- update the tree-model and table-model grammars so `REMOVE DATANODE` accepts exactly one DataNode ID
- construct a singleton DataNode ID list in both AST builders
- verify that tree-model and table-model parsers accept single-node `REMOVE DATANODE` / `REMOVE CONFIGNODE` statements and reject multiple node IDs
- remove the integration test for removing two DataNodes in one statement
## Tests
- `mvn -q test -pl iotdb-core/datanode -am -Dtest=RemoveNodeSingleNodeParseTest,RemoveNodeSingleNodeStatementTest -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable multi-node REMOVE statements [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #18360:
URL: https://github.com/apache/iotdb/pull/18360#issuecomment-5126430193
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18360) **Quality Gate failed**
Failed conditions
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18360) (required ≥ A)
<!-- sqra:qg_revision=443ec8b9c25f2ec8d4f7dd57c10b7ba50fe651c4e06d9e5009a3ee3ef8149010 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18360)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable multi-node REMOVE statements [iotdb]
Posted by "CRZbulabula (via GitHub)" <gi...@apache.org>.
CRZbulabula merged PR #18360:
URL: https://github.com/apache/iotdb/pull/18360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable multi-node REMOVE statements [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #18360:
URL: https://github.com/apache/iotdb/pull/18360#issuecomment-5126787540
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/18360?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 43.41%. Comparing base ([`4861027`](https://app.codecov.io/gh/apache/iotdb/commit/486102749ddd57f2d2a769f6fa478875cbb21bd2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`63a44a7`](https://app.codecov.io/gh/apache/iotdb/commit/63a44a745a4ed318a42434631d2d3ff2504591b9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 10 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18360 +/- ##
============================================
+ Coverage 43.14% 43.41% +0.27%
Complexity 374 374
============================================
Files 5364 5366 +2
Lines 382623 382956 +333
Branches 49749 49809 +60
============================================
+ Hits 165077 166259 +1182
+ Misses 217546 216697 -849
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/iotdb/pull/18360?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org