[GitHub] [gobblin] phet commented on a change in pull request #3382: [GOBBLIN-1527] Add finder `latestFlowGroupExecutions` to `FlowExecutions` endpoint.

[GitBox <gi...@apache.org>]

phet commented on a change in pull request #3382:
URL: https://github.com/apache/gobblin/pull/3382#discussion_r701526258



##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/FsJobStatusRetriever.java
##########
@@ -83,7 +84,7 @@ public FsJobStatusRetriever(Config config, MultiContextIssueRepository issueRepo
       }
       return jobStatuses.iterator();
     } catch (IOException e) {
-      log.error("IOException encountered when retrieving job statuses for flow: {},{},{}", flowGroup, flowName, flowExecutionId, e);
+      log.error(String.format("IOException encountered when retrieving job statuses for flow: %s,%s,%s", flowGroup, flowName, flowExecutionId), e);

Review comment:
       I changed this because my understanding of signature, `(String, Object...)`, is that it treats all trailing args as format string interpolations, not recognizing that the final one might be `? extends Throwable`.  thus it won't print the stacktrace, as `(String, Throwable)` would.  if that's incorrect, or I misinterpreted the intent here, let's revert these lines.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org