You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ws.apache.org by ve...@apache.org on 2015/08/26 22:05:38 UTC

svn commit: r1697997 - in /webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom: OMElementImpl.java OMSourcedElementImpl.java

Author: veithen
Date: Wed Aug 26 20:05:38 2015
New Revision: 1697997

URL: http://svn.apache.org/r1697997
Log:
Eliminate the last non trivial OMElementImpl constructor.

Modified:
    webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMElementImpl.java
    webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMSourcedElementImpl.java

Modified: webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMElementImpl.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMElementImpl.java?rev=1697997&r1=1697996&r2=1697997&view=diff
==============================================================================
--- webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMElementImpl.java (original)
+++ webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMElementImpl.java Wed Aug 26 20:05:38 2015
@@ -28,8 +28,6 @@ import org.apache.axiom.om.OMException;
 import org.apache.axiom.om.OMFactory;
 import org.apache.axiom.om.OMNamespace;
 import org.apache.axiom.om.OMNode;
-import org.apache.axiom.om.OMXMLParserWrapper;
-import org.apache.axiom.om.impl.common.AxiomContainer;
 import org.apache.axiom.om.impl.common.AxiomElement;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
@@ -44,16 +42,6 @@ public class OMElementImpl extends OMNod
     
     private int lineNumber;
 
-    public OMElementImpl(OMContainer parent, String localName, OMNamespace ns, OMXMLParserWrapper builder,
-                    OMFactory factory, boolean generateNSDecl) {
-        super(factory);
-        coreSetBuilder(builder);
-        if (parent != null) {
-            ((AxiomContainer)parent).addChild(this, builder != null);
-        }
-        initName(localName, ns, generateNSDecl);
-    }
-
     public OMElementImpl(OMFactory factory) {
         super(factory);
     }

Modified: webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMSourcedElementImpl.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMSourcedElementImpl.java?rev=1697997&r1=1697996&r2=1697997&view=diff
==============================================================================
--- webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMSourcedElementImpl.java (original)
+++ webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMSourcedElementImpl.java Wed Aug 26 20:05:38 2015
@@ -103,10 +103,11 @@ public class OMSourcedElementImpl extend
      */
     public OMSourcedElementImpl(String localName, OMNamespace ns, OMFactory factory,
                                 OMDataSource source) {
-        super(null, localName, null, null, factory, false);
+        super(factory);
         if (source == null) {
             throw new IllegalArgumentException("OMDataSource can't be null");
         }
+        internalSetLocalName(localName);
         dataSource = source;
         isExpanded = false;
         // Normalize the namespace. Note that this also covers the case where the
@@ -134,11 +135,11 @@ public class OMSourcedElementImpl extend
      * @param source
      */
     public OMSourcedElementImpl(QName qName, OMFactory factory, OMDataSource source) {
-        //create a namespace
-        super(null, qName.getLocalPart(), null, null, factory, false);
+        super(factory);
         if (source == null) {
             throw new IllegalArgumentException("OMDataSource can't be null");
         }
+        internalSetLocalName(qName.getLocalPart());
         dataSource = source;
         isExpanded = false;
         if (!isLossyPrefix(dataSource)) {