You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/08/10 07:47:33 UTC
[GitHub] [incubator-linkis] binbinCheng opened a new pull request, #2674: [ISSUES-2672]Add DownloadServiceImplTest unit test
binbinCheng opened a new pull request, #2674:
URL: https://github.com/apache/incubator-linkis/pull/2674
Add DownloadServiceImplTest unit test
Related issue #2672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #2674: [ISSUES-2672]Add DownloadServiceImplTest unit test
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #2674:
URL: https://github.com/apache/incubator-linkis/pull/2674#discussion_r943054319
##########
linkis-public-enhancements/linkis-bml/linkis-bml-server/src/test/java/org/apache/linkis/bml/service/DownloadServiceImplTest.java:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.linkis.bml.service;
+
+import org.apache.linkis.bml.dao.DownloadDao;
+import org.apache.linkis.bml.entity.DownloadModel;
+import org.apache.linkis.bml.service.impl.DownloadServiceImpl;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+import java.util.Date;
+
+/** DownloadServiceImpl Tester */
+@ExtendWith(MockitoExtension.class)
+public class DownloadServiceImplTest {
+
+ @InjectMocks private DownloadServiceImpl downloadServiceImpl;
+
+ @Mock private DownloadDao downloadDao;
+
+ @Test
+ public void testAddDownloadRecord() throws Exception {
+ // TODO: Test goes here...
Review Comment:
please delete uuseless annotation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone merged pull request #2674: [ISSUES-2672]Add DownloadServiceImplTest unit test
Posted by GitBox <gi...@apache.org>.
casionone merged PR #2674:
URL: https://github.com/apache/incubator-linkis/pull/2674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #2674: [ISSUES-2672]Add DownloadServiceImplTest unit test
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2674:
URL: https://github.com/apache/incubator-linkis/pull/2674#issuecomment-1210326143
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2674?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2674](https://codecov.io/gh/apache/incubator-linkis/pull/2674?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f5d244) into [dev-1.2.1](https://codecov.io/gh/apache/incubator-linkis/commit/1cc885fe0481e59d15703c12f11ba1efdab356fe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1cc885f) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## dev-1.2.1 #2674 +/- ##
===============================================
+ Coverage 15.92% 15.94% +0.02%
- Complexity 1307 1310 +3
===============================================
Files 742 742
Lines 23252 23252
Branches 3441 3441
===============================================
+ Hits 3702 3708 +6
+ Misses 19067 19061 -6
Partials 483 483
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/2674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...s/manager/engineplugin/jdbc/ConnectionManager.java](https://codecov.io/gh/apache/incubator-linkis/pull/2674/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9qZGJjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saW5raXMvbWFuYWdlci9lbmdpbmVwbHVnaW4vamRiYy9Db25uZWN0aW9uTWFuYWdlci5qYXZh) | `44.07% <0.00%> (-0.48%)` | :arrow_down: |
| [...apache/linkis/scheduler/queue/LoopArrayQueue.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2674/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvTG9vcEFycmF5UXVldWUuc2NhbGE=) | `33.96% <0.00%> (+1.88%)` | :arrow_up: |
| [...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2674/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvZmlmb3F1ZXVlL0ZJRk9Vc2VyQ29uc3VtZXIuc2NhbGE=) | `37.77% <0.00%> (+2.22%)` | :arrow_up: |
| [...e/linkis/bml/service/impl/DownloadServiceImpl.java](https://codecov.io/gh/apache/incubator-linkis/pull/2674/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLWJtbC9saW5raXMtYm1sLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2JtbC9zZXJ2aWNlL2ltcGwvRG93bmxvYWRTZXJ2aWNlSW1wbC5qYXZh) | `100.00% <0.00%> (+100.00%)` | :arrow_up: |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org