You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@groovy.apache.org by "Damir Murat (Jira)" <ji...@apache.org> on 2020/05/28 09:56:00 UTC

[jira] [Created] (GROOVY-9577) ModuleNode should use LinkedHashMap for imports Map

Damir Murat created GROOVY-9577:
-----------------------------------

             Summary: ModuleNode should use LinkedHashMap for imports Map
                 Key: GROOVY-9577
                 URL: https://issues.apache.org/jira/browse/GROOVY-9577
             Project: Groovy
          Issue Type: Bug
          Components: ast builder
    Affects Versions: 3.0.4
            Reporter: Damir Murat


One of last statements in AstBuilder.visitImportDeclaration() are
{code:java}
moduleNode.addImport(alias, classNode, annotationNodeList);

importNode = last(moduleNode.getImports());
{code}
Since ModuleNode.imports is a HashMap, last() method return unpredictable result.

I guess this can be fixed by changing the implementation of ModuleNode.imports into LinkedHashMap instead of HashMap as is currently.

I stumbled on this while trying to use CodeNarc with the latest Groovy.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)