You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vchiapaikeo (via GitHub)" <gi...@apache.org> on 2023/04/17 00:13:20 UTC

[GitHub] [airflow] vchiapaikeo opened a new pull request, #30675: Updated app to support configuring the caching hash method for FIPS v2

vchiapaikeo opened a new pull request, #30675:
URL: https://github.com/apache/airflow/pull/30675

   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   Created in response to a stale PR at the direction of @eladkal: https://github.com/apache/airflow/pull/28846
   
   This was created to address issues that occurred in a FIPS enabled environment. This allows you to set the CACHING_HASH_METHOD config value to override the default of md5. Also updates the serialized_dag hash code to work even in a FIPS environment.
   
   Testing:
   
   Started up breeze and ensured webserver started fine:
   
   <img width="1440" alt="image" src="https://user-images.githubusercontent.com/9200263/232351404-b5161932-7dfd-4cb1-942d-208f37e0872b.png">
   
   Inspected serialized dag dag_hash field:
   
   <img width="1105" alt="image" src="https://user-images.githubusercontent.com/9200263/232351412-e0046563-5a91-4d13-8950-37c39a6b5c3b.png">
   
   Modified the hash method to sha256 and restarted breeze with this configuration in `files/airflow-breeze-config/init.sh`:
   
   ```bash
   export AIRFLOW__WEBSERVER__CACHING_HASH_METHOD=sha256
   export AIRFLOW__WEBSERVER__EXPOSE_CONFIG=True
   ```
   
   Checked configuration:
   
   <img width="1440" alt="image" src="https://user-images.githubusercontent.com/9200263/232351570-62c29520-283d-4727-9b21-dd37bb976707.png">
   
   
   Rechecked dag hash field:
   
   <img width="1094" alt="image" src="https://user-images.githubusercontent.com/9200263/232351595-e44b4b9b-542d-4bb4-a224-4ddf5926df19.png">
   
   Test a simple dag:
   
   <img width="1148" alt="image" src="https://user-images.githubusercontent.com/9200263/232351695-bb136e67-9351-4d81-9789-860b093ce1ce.png">
   
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] eladkal commented on a diff in pull request #30675: Updated app to support configuring the caching hash method for FIPS v2

Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #30675:
URL: https://github.com/apache/airflow/pull/30675#discussion_r1169022480


##########
airflow/config_templates/config.yml:
##########
@@ -1692,6 +1692,13 @@ webserver:
       type: string
       example: ~
       default: "5 per 40 second"
+    caching_hash_method:
+      description: |
+        The caching algorithm used by the webserver. Must be a valid hashlib function name.
+      version_added:

Review Comment:
   I guess we should put 2.7.0 here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #30675: Updated app to support configuring the caching hash method for FIPS v2

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #30675:
URL: https://github.com/apache/airflow/pull/30675


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on a diff in pull request #30675: Updated app to support configuring the caching hash method for FIPS v2

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #30675:
URL: https://github.com/apache/airflow/pull/30675#discussion_r1169038538


##########
airflow/config_templates/config.yml:
##########
@@ -1692,6 +1692,13 @@ webserver:
       type: string
       example: ~
       default: "5 per 40 second"
+    caching_hash_method:
+      description: |
+        The caching algorithm used by the webserver. Must be a valid hashlib function name.
+      version_added:

Review Comment:
   I know I wrote on slack that it is 2.7 - but on a hindsight - unless it's not too late - that one looks super safe



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on a diff in pull request #30675: Updated app to support configuring the caching hash method for FIPS v2

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #30675:
URL: https://github.com/apache/airflow/pull/30675#discussion_r1169062051


##########
airflow/config_templates/config.yml:
##########
@@ -1692,6 +1692,13 @@ webserver:
       type: string
       example: ~
       default: "5 per 40 second"
+    caching_hash_method:
+      description: |
+        The caching algorithm used by the webserver. Must be a valid hashlib function name.
+      version_added:

Review Comment:
   Yeah. Can you please add 2.6.0 `added` PR @vchiapaikeo :)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] vchiapaikeo commented on a diff in pull request #30675: Updated app to support configuring the caching hash method for FIPS v2

Posted by "vchiapaikeo (via GitHub)" <gi...@apache.org>.
vchiapaikeo commented on code in PR #30675:
URL: https://github.com/apache/airflow/pull/30675#discussion_r1169049477


##########
airflow/config_templates/config.yml:
##########
@@ -1692,6 +1692,13 @@ webserver:
       type: string
       example: ~
       default: "5 per 40 second"
+    caching_hash_method:
+      description: |
+        The caching algorithm used by the webserver. Must be a valid hashlib function name.
+      version_added:

Review Comment:
   Ah whoops! Let me know if I can do a fast follow up here to add 2.7.0 here @potiuk 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on a diff in pull request #30675: Updated app to support configuring the caching hash method for FIPS v2

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #30675:
URL: https://github.com/apache/airflow/pull/30675#discussion_r1169039288


##########
airflow/config_templates/config.yml:
##########
@@ -1692,6 +1692,13 @@ webserver:
       type: string
       example: ~
       default: "5 per 40 second"
+    caching_hash_method:
+      description: |
+        The caching algorithm used by the webserver. Must be a valid hashlib function name.
+      version_added:

Review Comment:
   Ah. I see it is missing at all :(



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #30675: Updated app to support configuring the caching hash method for FIPS v2

Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on code in PR #30675:
URL: https://github.com/apache/airflow/pull/30675#discussion_r1169055498


##########
airflow/config_templates/config.yml:
##########
@@ -1692,6 +1692,13 @@ webserver:
       type: string
       example: ~
       default: "5 per 40 second"
+    caching_hash_method:
+      description: |
+        The caching algorithm used by the webserver. Must be a valid hashlib function name.
+      version_added:

Review Comment:
   Let's tag it 2.6.0. I will no longer do the RC today



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on a diff in pull request #30675: Updated app to support configuring the caching hash method for FIPS v2

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #30675:
URL: https://github.com/apache/airflow/pull/30675#discussion_r1169037562


##########
airflow/config_templates/config.yml:
##########
@@ -1692,6 +1692,13 @@ webserver:
       type: string
       example: ~
       default: "5 per 40 second"
+    caching_hash_method:
+      description: |
+        The caching algorithm used by the webserver. Must be a valid hashlib function name.
+      version_added:

Review Comment:
   Unless @ephraimbuddy will decide to merge in to 2.6.0 ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] vchiapaikeo commented on a diff in pull request #30675: Updated app to support configuring the caching hash method for FIPS v2

Posted by "vchiapaikeo (via GitHub)" <gi...@apache.org>.
vchiapaikeo commented on code in PR #30675:
URL: https://github.com/apache/airflow/pull/30675#discussion_r1169211237


##########
airflow/config_templates/config.yml:
##########
@@ -1692,6 +1692,13 @@ webserver:
       type: string
       example: ~
       default: "5 per 40 second"
+    caching_hash_method:
+      description: |
+        The caching algorithm used by the webserver. Must be a valid hashlib function name.
+      version_added:

Review Comment:
   Yes, not a problem. PR: https://github.com/apache/airflow/pull/30688



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #30675: Updated app to support configuring the caching hash method for FIPS v2

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30675:
URL: https://github.com/apache/airflow/pull/30675#issuecomment-1511728829

   Nice, thanks for picking this one up!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org