You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/11/16 19:18:20 UTC

[GitHub] [maven-jlink-plugin] rfscholte edited a comment on pull request #16: [MJLINK-36] WIP – draft for java9 ToolProvider via java9 source folder.

rfscholte edited a comment on pull request #16:
URL: https://github.com/apache/maven-jlink-plugin/pull/16#issuecomment-728255698


   PR looks much better already.
   > What about JDK9+ and Toolchains?
   
   Toolchains always wins
   
   > Does JLinkMojo::getModulePathElements need an update?
   
   Not sure if I understand the question, but what I do know is dat some ugly parts of the maven-compiler-plugin were copied to this plugin, which should have been solved cleaner. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org