You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "liangyepianzhou (via GitHub)" <gi...@apache.org> on 2023/08/25 07:25:07 UTC

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #21063: [improve] [broker] Improve cache handling for partitioned topic metadata when doing lookup

liangyepianzhou commented on code in PR #21063:
URL: https://github.com/apache/pulsar/pull/21063#discussion_r1305288331


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -3060,6 +3063,8 @@ public CompletableFuture<PartitionedTopicMetadata> fetchPartitionedTopicMetadata
                                                                             }
                                                                         });
                                                             } else {
+                                                                log.error("[{}] The create partitioned topic metadata"

Review Comment:
   ```suggestion
                                                                   log.error("[{}] The operation of creating partitioned"
                                                                           + " topic metadata failed", topicName, ex);
   ```



##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -3050,8 +3050,11 @@ public CompletableFuture<PartitionedTopicMetadata> fetchPartitionedTopicMetadata
                                                             if (ex.getCause()
                                                                     instanceof MetadataStoreException
                                                                     .AlreadyExistsException) {
+                                                                log.info("[{}] The partitioned topic is already"
+                                                                        + " created, try to refresh the cache and read"
+                                                                        + " again.", topicName.toString());

Review Comment:
   ```suggestion
                                                                   log.info("[{}] The partitioned topic is already"
                                                                           + " created, try to refresh the cache and read"
                                                                           + " again.", topicName);
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org