You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by gi...@git.apache.org on 2017/10/02 19:47:36 UTC

[GitHub] Antonio-Maranhao opened a new pull request #986: Refactor map/reduce views to use Redux

Antonio-Maranhao opened a new pull request #986: Refactor map/reduce views to use Redux
URL: https://github.com/apache/couchdb-fauxton/pull/986
 
 
   
   ## Overview
   
   
   - [x] Updated map/reduce views to use Redux version of IndexResults components
   - [x] Removed non-Redux components from `index-results` 
   - [x] Removed Mango resources from `documents/resources.js` 
   - [x] Query Options are now preserved when switching between different views, all docs, design docs. Also, if any of the options is enabled (except for All docs) the header is highlighted to indicate this fact.
   
   Extra 
   - [x] Bug fix: when creating a new view in an existing design doc, an error message is showed and the page doesn't change to the new view.
   
   ## Testing recommendations
   
   - Select a view and browse the results
     - Change display mode (Table/Metadata/JSON)
     - Click on next/previous page
     - Change the num of 
     - Set query options and click Run Query
       - Check that {}JSON link includes options from Query Options
       - Check that Reduce option only shows for views that contain a reduce function
          - When the Reduce option is enabled, only the Metadata layout is enabled
    - Create a new view in an existing design doc
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services