You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-commits@lucene.apache.org by ma...@apache.org on 2009/05/22 17:30:32 UTC

svn commit: r777577 - in /lucene/solr/trunk: CHANGES.txt src/java/org/apache/solr/search/function/OrdFieldSource.java

Author: markrmiller
Date: Fri May 22 15:30:32 2009
New Revision: 777577

URL: http://svn.apache.org/viewvc?rev=777577&view=rev
Log:
SOLR-1182: Fix bug in OrdFieldSource#equals which could cause a bug with OrdFieldSource caching on OrdFieldSource#hashcode collisions. 

Modified:
    lucene/solr/trunk/CHANGES.txt
    lucene/solr/trunk/src/java/org/apache/solr/search/function/OrdFieldSource.java

Modified: lucene/solr/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/CHANGES.txt?rev=777577&r1=777576&r2=777577&view=diff
==============================================================================
--- lucene/solr/trunk/CHANGES.txt (original)
+++ lucene/solr/trunk/CHANGES.txt Fri May 22 15:30:32 2009
@@ -387,6 +387,9 @@
 
 47. SOLR-1174: Fix Logging admin form submit url for multicore. (Jacob Singh via shalin)
 
+48. SOLR-1182: Fix bug in OrdFieldSource#equals which could cause a bug with OrdFieldSource caching
+               on OrdFieldSource#hashcode collisions. (Mark Miller)
+
 
 Other Changes
 ----------------------

Modified: lucene/solr/trunk/src/java/org/apache/solr/search/function/OrdFieldSource.java
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/search/function/OrdFieldSource.java?rev=777577&r1=777576&r2=777577&view=diff
==============================================================================
--- lucene/solr/trunk/src/java/org/apache/solr/search/function/OrdFieldSource.java (original)
+++ lucene/solr/trunk/src/java/org/apache/solr/search/function/OrdFieldSource.java Fri May 22 15:30:32 2009
@@ -85,7 +85,7 @@
   }
 
   public boolean equals(Object o) {
-    return o.getClass() == OrdFieldSource.class && this.field.equals(field);
+    return o.getClass() == OrdFieldSource.class && this.field.equals(((OrdFieldSource)o).field);
   }
 
   private static final int hcode = OrdFieldSource.class.hashCode();