You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/12/21 14:30:13 UTC
Review Request 41603: Cleaned up quota HTTP handling code and tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
Bugs: MESOS-3960
https://issues.apache.org/jira/browse/MESOS-3960
Repository: mesos
Description
-------
Define a variable earlier in the handler for clarity; add consts and
using directive where appropriate.
Diffs
-----
src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1
Diff: https://reviews.apache.org/r/41603/diff/
Testing
-------
make check on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
Re: Review Request 41603: Cleaned up quota HTTP handling code and
tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Dec. 21, 2015, 11:38 p.m., Guangya Liu wrote:
> > src/master/quota_handler.cpp, lines 57-60
> > <https://reviews.apache.org/r/41603/diff/2/?file=1173823#file1173823line57>
> >
> > Not yours but it would be greate to update it as following:
> >
> > using mesos::quota::QuotaInfo;
> >
> > using process::Future;
> > using process::Owned;
I grepped the codebase and found out that we indeed order `using` groups alphabetically. The only exception (and we are unfortunately inconsistent about it) is STL `using`s: sometimes we put them first (like with STL includes), sometimes alphabetically (after `process::*`). I'll reorder the whole using section.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/#review111555
-----------------------------------------------------------
On Dec. 22, 2015, 11:01 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41603/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2015, 11:01 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Define a variable earlier in the handler for clarity; add consts and
> using directive where appropriate.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
> src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1
>
> Diff: https://reviews.apache.org/r/41603/diff/
>
>
> Testing
> -------
>
> make check on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 41603: Cleaned up quota HTTP handling code and
tests.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/#review111555
-----------------------------------------------------------
src/master/quota_handler.cpp (lines 57 - 60)
<https://reviews.apache.org/r/41603/#comment171756>
Not yours but it would be greate to update it as following:
using mesos::quota::QuotaInfo;
using process::Future;
using process::Owned;
- Guangya Liu
On 十二月 21, 2015, 2:17 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41603/
> -----------------------------------------------------------
>
> (Updated 十二月 21, 2015, 2:17 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Define a variable earlier in the handler for clarity; add consts and
> using directive where appropriate.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
> src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1
>
> Diff: https://reviews.apache.org/r/41603/diff/
>
>
> Testing
> -------
>
> make check on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 41603: Cleaned up quota HTTP handling code and
tests.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/#review111644
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41514, 41515, 41603]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 22, 2015, 6:08 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41603/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2015, 6:08 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Define a variable earlier in the handler for clarity; add consts; add
> and re-order using directive where appropriate.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
> src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1
>
> Diff: https://reviews.apache.org/r/41603/diff/
>
>
> Testing
> -------
>
> make check on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 41603: Cleaned up quota HTTP handling code and
tests.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/#review111641
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Dec. 22, 2015, 6:08 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41603/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2015, 6:08 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Define a variable earlier in the handler for clarity; add consts; add
> and re-order using directive where appropriate.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
> src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1
>
> Diff: https://reviews.apache.org/r/41603/diff/
>
>
> Testing
> -------
>
> make check on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 41603: Cleaned up quota HTTP handling code and
tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/
-----------------------------------------------------------
(Updated Dec. 22, 2015, 6:08 p.m.)
Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
Changes
-------
Added ab include.
Bugs: MESOS-3960
https://issues.apache.org/jira/browse/MESOS-3960
Repository: mesos
Description
-------
Define a variable earlier in the handler for clarity; add consts; add
and re-order using directive where appropriate.
Diffs (updated)
-----
src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1
Diff: https://reviews.apache.org/r/41603/diff/
Testing
-------
make check on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
Re: Review Request 41603: Cleaned up quota HTTP handling code and
tests.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/#review111608
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41514, 41515, 41603]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 22, 2015, 11:16 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41603/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2015, 11:16 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Define a variable earlier in the handler for clarity; add consts; add
> and re-order using directive where appropriate.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
> src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1
>
> Diff: https://reviews.apache.org/r/41603/diff/
>
>
> Testing
> -------
>
> make check on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 41603: Cleaned up quota HTTP handling code and
tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/
-----------------------------------------------------------
(Updated Dec. 22, 2015, 11:16 a.m.)
Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
Changes
-------
Re-order includes.
Bugs: MESOS-3960
https://issues.apache.org/jira/browse/MESOS-3960
Repository: mesos
Description (updated)
-------
Define a variable earlier in the handler for clarity; add consts; add
and re-order using directive where appropriate.
Diffs (updated)
-----
src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1
Diff: https://reviews.apache.org/r/41603/diff/
Testing
-------
make check on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
Re: Review Request 41603: Cleaned up quota HTTP handling code and
tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/
-----------------------------------------------------------
(Updated Dec. 22, 2015, 11:01 a.m.)
Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
Changes
-------
Rebased.
Bugs: MESOS-3960
https://issues.apache.org/jira/browse/MESOS-3960
Repository: mesos
Description
-------
Define a variable earlier in the handler for clarity; add consts and
using directive where appropriate.
Diffs (updated)
-----
src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1
Diff: https://reviews.apache.org/r/41603/diff/
Testing
-------
make check on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
Re: Review Request 41603: Cleaned up quota HTTP handling code and
tests.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/#review111531
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41514, 41515, 41603]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 21, 2015, 2:17 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41603/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2015, 2:17 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Define a variable earlier in the handler for clarity; add consts and
> using directive where appropriate.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
> src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1
>
> Diff: https://reviews.apache.org/r/41603/diff/
>
>
> Testing
> -------
>
> make check on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 41603: Cleaned up quota HTTP handling code and
tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/
-----------------------------------------------------------
(Updated Dec. 21, 2015, 2:17 p.m.)
Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
Bugs: MESOS-3960
https://issues.apache.org/jira/browse/MESOS-3960
Repository: mesos
Description
-------
Define a variable earlier in the handler for clarity; add consts and
using directive where appropriate.
Diffs (updated)
-----
src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1
Diff: https://reviews.apache.org/r/41603/diff/
Testing
-------
make check on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
Re: Review Request 41603: Cleaned up quota HTTP handling code and
tests.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/#review111461
-----------------------------------------------------------
Ship it!
Ship It!
- Joerg Schad
On Dec. 21, 2015, 1:30 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41603/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2015, 1:30 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Define a variable earlier in the handler for clarity; add consts and
> using directive where appropriate.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
> src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1
>
> Diff: https://reviews.apache.org/r/41603/diff/
>
>
> Testing
> -------
>
> make check on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 41603: Cleaned up quota HTTP handling code and
tests.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/#review111462
-----------------------------------------------------------
src/master/quota_handler.cpp (line 60)
<https://reviews.apache.org/r/41603/#comment171669>
Could you add a blank line between using and namespace? THX
- Joerg Schad
On Dec. 21, 2015, 1:30 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41603/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2015, 1:30 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Define a variable earlier in the handler for clarity; add consts and
> using directive where appropriate.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
> src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1
>
> Diff: https://reviews.apache.org/r/41603/diff/
>
>
> Testing
> -------
>
> make check on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>