[GitHub] [avro] KyleSchoonover commented on a diff in pull request #1653: AVRO-3497 Simplify conditional expression

[GitBox <gi...@apache.org>]

KyleSchoonover commented on code in PR #1653:
URL: https://github.com/apache/avro/pull/1653#discussion_r854358030


##########
lang/csharp/src/apache/main/Generic/GenericEnum.cs:
##########
@@ -70,10 +70,12 @@ public GenericEnum(EnumSchema schema, string value)
         /// <inheritdoc/>
         public override bool Equals(object obj)
         {
-            if (obj == this) return true;
-            return (obj != null && obj is GenericEnum)
-                ? Value.Equals((obj as GenericEnum).Value, System.StringComparison.Ordinal)
-                : false;
+            if (obj == this)
+            {
+                return true;
+            }
+
+            return obj != null && obj is GenericEnum && Value.Equals((obj as GenericEnum).Value, System.StringComparison.Ordinal);
         }

Review Comment:
   Let me write an inheritance test.  I'm not really changing what is already there.  It's the exact same checks.  Potentially, any class that inherits may have to override equals.  
   
   I will be recreating the MR, and address the testing there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org