You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by "Philippe M. Chiasson" <go...@cpan.org> on 2003/05/26 09:40:28 UTC
[mp1] Apache::Status override keys in menu_item() sub
In this old report
[http://marc.theaimsgroup.com/?l=apache-modperl&m=101559176217056&w=2]
Enrico Sorcinelli notes the fact that it is possible to override the
built-in menus in Apache::Status with the menu_item() API.
He believes this is a bad thing, and provided a patch that will disable
this with a warning.
I don't see a good reason why people shouldn't be able to do that. And
after all, even if you block it thru menu_item, there will still be ways
to achieve that.
I can't find a good reason why people would want to override the
built-in menus either. But I would prefer if the choice remained in the
users hands.
If nobody objects to this one, I'd consider the issue closed and remove
it from STATUS
--
-- -----------------------------------------------------------------------------
Philippe M. Chiasson /gozer\@(cpan|ectoplasm)\.org/ 88C3A5A5 (122FF51B/C634E37B)
http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3 A5A5
Q: It is impossible to make anything foolproof because fools are so ingenious.
perl -e'$$=\${gozer};{$_=unpack(P7,pack(L,$$));/^JAm_pH\n$/&&print||$$++&&redo}'
Re: [mp1] Apache::Status override keys in menu_item() sub
Posted by Enrico Sorcinelli <e....@pisa.iol.it>.
On Mon, 26 May 2003 17:54:25 +1000
Stas Bekman <st...@stason.org> wrote:
Hi all,
> Philippe M. Chiasson wrote:
> > In this old report
> > [http://marc.theaimsgroup.com/?l=apache-modperl&m=101559176217056&w=2]
> > Enrico Sorcinelli notes the fact that it is possible to override the
> > built-in menus in Apache::Status with the menu_item() API.
> >
> > He believes this is a bad thing, and provided a patch that will disable
> > this with a warning.
> >
> > I don't see a good reason why people shouldn't be able to do that. And
> > after all, even if you block it thru menu_item, there will still be ways
> > to achieve that.
> >
Yes, you can work around but at cost of little bit Apache core hacking,
not directly from a shared API.
> > I can't find a good reason why people would want to override the
> > built-in menus either. But I would prefer if the choice remained in the
> > users hands.
> >
"Users hands" that intend you is the hands of Apache mod_perl modules
developers, not final users! :-)
I don't know any modules that leave on the final user hand the possibility
to skip the Apachge::Status plugin installation.
The problem is that it doesn't exists an Apache::Status items repository
and if a mod_perl module overrides Status items the final user can mistake.
I think that another simple idea is to patch Apache::Status in order to install
plugged keys by inserting also the module namespace before the key to avoid
any conflicts.
> > If nobody objects to this one, I'd consider the issue closed and remove
> > it from STATUS
>
> +1 to close -- I can see that this might be useful, if an evil module
> overrides the core functionality as part of its load. But this is a debug
> module, and different people will have a different concept of DWIM in this case.
>
Yes, it is a debug module, but useful! :-)
by
- Enrico
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [mp1] Apache::Status override keys in menu_item() sub
Posted by "Philippe M. Chiasson" <go...@cpan.org>.
On Mon, 2003-05-26 at 15:54, Stas Bekman wrote:
> Philippe M. Chiasson wrote:
> > In this old report
> > [http://marc.theaimsgroup.com/?l=apache-modperl&m=101559176217056&w=2]
> > Enrico Sorcinelli notes the fact that it is possible to override the
> > built-in menus in Apache::Status with the menu_item() API.
> >
> > He believes this is a bad thing, and provided a patch that will disable
> > this with a warning.
> >
> > I don't see a good reason why people shouldn't be able to do that. And
> > after all, even if you block it thru menu_item, there will still be ways
> > to achieve that.
> >
> > I can't find a good reason why people would want to override the
> > built-in menus either. But I would prefer if the choice remained in the
> > users hands.
> >
> > If nobody objects to this one, I'd consider the issue closed and remove
> > it from STATUS
>
> +1 to close -- I can see that this might be useful, if an evil module
> overrides the core functionality as part of its load. But this is a debug
> module, and different people will have a different concept of DWIM in this case.
Exactly my point ;-)
> Though it's probably a good idea to CC the original "bug" submitter when
> discussing/closing those issues.
Planned to do just that. Patch on the way.
> __________________________________________________________________
> Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
> http://stason.org/ mod_perl Guide ---> http://perl.apache.org
> mailto:stas@stason.org http://use.perl.org http://apacheweek.com
> http://modperlbook.org http://apache.org http://ticketmaster.com
--
-- -----------------------------------------------------------------------------
Philippe M. Chiasson /gozer\@(cpan|ectoplasm)\.org/ 88C3A5A5 (122FF51B/C634E37B)
http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3 A5A5
Q: It is impossible to make anything foolproof because fools are so ingenious.
perl -e'$$=\${gozer};{$_=unpack(P7,pack(L,$$));/^JAm_pH\n$/&&print||$$++&&redo}'
Re: [mp1] Apache::Status override keys in menu_item() sub
Posted by Stas Bekman <st...@stason.org>.
Philippe M. Chiasson wrote:
> In this old report
> [http://marc.theaimsgroup.com/?l=apache-modperl&m=101559176217056&w=2]
> Enrico Sorcinelli notes the fact that it is possible to override the
> built-in menus in Apache::Status with the menu_item() API.
>
> He believes this is a bad thing, and provided a patch that will disable
> this with a warning.
>
> I don't see a good reason why people shouldn't be able to do that. And
> after all, even if you block it thru menu_item, there will still be ways
> to achieve that.
>
> I can't find a good reason why people would want to override the
> built-in menus either. But I would prefer if the choice remained in the
> users hands.
>
> If nobody objects to this one, I'd consider the issue closed and remove
> it from STATUS
+1 to close -- I can see that this might be useful, if an evil module
overrides the core functionality as part of its load. But this is a debug
module, and different people will have a different concept of DWIM in this case.
Though it's probably a good idea to CC the original "bug" submitter when
discussing/closing those issues.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org