You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by trvskn <gi...@git.apache.org> on 2018/06/09 00:15:29 UTC

[GitHub] spark pull request #21519: [SPARK-24412] [SQL] Adding docs about automagical...

GitHub user trvskn opened a pull request:

    https://github.com/apache/spark/pull/21519

    [SPARK-24412] [SQL] Adding docs about automagical type casting in `isin` and `isInCollection` APIs

    ## What changes were proposed in this pull request?
    Update documentation for `isInCollection` API to clealy explain the "auto-casting" of elements if their types are different.
    
    ## How was this patch tested?
    No-Op


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/trvskn/spark sql-doc-update

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21519.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21519
    
----
commit 741c60f9f373ec9f38b8eab2c73dde1a88a56fd4
Author: Thiruvasakan Paramasivan <th...@...>
Date:   2018-06-08T23:43:39Z

    Update documentation for 'isInCollection' API
    
    Update documentation for `isInCollection` API to clealy explain the "auto-casting" of elements if their types are different.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21519: [SPARK-24412] [SQL] Adding docs about automagical type c...

Posted by dbtsai <gi...@git.apache.org>.
Github user dbtsai commented on the issue:

    https://github.com/apache/spark/pull/21519
  
    Merged into master as it's only document changes. Congratulations on first PR! Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #21519: [SPARK-24412] [SQL] Adding docs about automagical...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/21519


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21519: [SPARK-24412] [SQL] Adding docs about automagical type c...

Posted by dbtsai <gi...@git.apache.org>.
Github user dbtsai commented on the issue:

    https://github.com/apache/spark/pull/21519
  
    add to whitelist


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org