You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (Created) (JIRA)" <ji...@apache.org> on 2011/10/26 09:25:32 UTC
[jira] [Created] (BOOKKEEPER-95) extends zookeeper JMX to monitor
and manage bookie server
extends zookeeper JMX to monitor and manage bookie server
---------------------------------------------------------
Key: BOOKKEEPER-95
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-95
Project: Bookkeeper
Issue Type: Sub-task
Components: bookkeeper-server
Affects Versions: 3.4.0
Reporter: Sijie Guo
we can extends/reuses zookeeper JMX until to monitor and manage bookie server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-95) extends zookeeper JMX to monitor
and manage bookie server
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188283#comment-13188283 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-95:
---------------------------------------------------------
bq. On 2012-01-17 17:12:20, Ivan Kelly wrote:
bq. > The bulk of the code in this patch could be removed if zookeeper's ZKMBeanRegistry was updated to allow easy extension. Have you looked at changing the ZK code? Of course, we'd need to continue to use the code in this patch until a version of zookeeper with the change is released, but i think it would make things cleaner.
yes. updating zookeeper MBeanRegistry would be better.
currently a hard coded DOMAIN is used in zookeeper MBeanRegistry#makeObjectName.
so it would be easy to extends MBeanRegistry#makeObjectName(path, bean) to MBeanRegistry#makeObjectName(domain, path, bean) to make things easier.
bq. On 2012-01-17 17:12:20, Ivan Kelly wrote:
bq. > bookkeeper-server/src/main/java/org/apache/bookkeeper/jmx/BKMBeanRegistry.java, line 39
bq. > <https://reviews.apache.org/r/3451/diff/1/?file=67674#file67674line39>
bq. >
bq. > Why is this static?
the code follows what zookeeper MBeanRegistry did. it tried to make MBeanRegistry a singleton. so it return instance in a static method #getInstance.
- Sijie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3451/#review4424
-----------------------------------------------------------
On 2012-01-11 01:04:57, Sijie Guo wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3451/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-11 01:04:57)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. we can extends/reuses zookeeper JMX until to monitor and manage bookie server
bq.
bq.
bq. This addresses bug BOOKKEEPER-95.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-95
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/jmx/BKMBeanInfo.java PRE-CREATION
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/jmx/BKMBeanRegistry.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3451/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sijie
bq.
bq.
> extends zookeeper JMX to monitor and manage bookie server
> ---------------------------------------------------------
>
> Key: BOOKKEEPER-95
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-95
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-95.patch, BOOKKEEPER-95.patch
>
>
> we can extends/reuses zookeeper JMX until to monitor and manage bookie server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-95) extends zookeeper JMX to monitor
and manage bookie server
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187808#comment-13187808 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-95:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3451/#review4424
-----------------------------------------------------------
The bulk of the code in this patch could be removed if zookeeper's ZKMBeanRegistry was updated to allow easy extension. Have you looked at changing the ZK code? Of course, we'd need to continue to use the code in this patch until a version of zookeeper with the change is released, but i think it would make things cleaner.
bookkeeper-server/src/main/java/org/apache/bookkeeper/jmx/BKMBeanRegistry.java
<https://reviews.apache.org/r/3451/#comment9935>
Why is this static?
- Ivan
On 2012-01-11 01:04:57, Sijie Guo wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3451/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-11 01:04:57)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. we can extends/reuses zookeeper JMX until to monitor and manage bookie server
bq.
bq.
bq. This addresses bug BOOKKEEPER-95.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-95
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/jmx/BKMBeanInfo.java PRE-CREATION
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/jmx/BKMBeanRegistry.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3451/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sijie
bq.
bq.
> extends zookeeper JMX to monitor and manage bookie server
> ---------------------------------------------------------
>
> Key: BOOKKEEPER-95
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-95
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-95.patch, BOOKKEEPER-95.patch
>
>
> we can extends/reuses zookeeper JMX until to monitor and manage bookie server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-95) extends zookeeper JMX to monitor
and manage bookie server
Posted by "Sijie Guo (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-95:
--------------------------------
Attachment: BOOKKEEPER-95.patch
extends zookeeper MBeanInfo and MBeanRegistry. change bookie mbeans's domain to org.apache.BookieServer
> extends zookeeper JMX to monitor and manage bookie server
> ---------------------------------------------------------
>
> Key: BOOKKEEPER-95
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-95
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Affects Versions: 3.4.0
> Reporter: Sijie Guo
> Attachments: BOOKKEEPER-95.patch
>
>
> we can extends/reuses zookeeper JMX until to monitor and manage bookie server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-95) extends zookeeper JMX to monitor
and manage bookie server
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183766#comment-13183766 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-95:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3451/
-----------------------------------------------------------
(Updated 2012-01-11 01:04:57.992380)
Review request for bookkeeper.
Summary
-------
we can extends/reuses zookeeper JMX until to monitor and manage bookie server
This addresses bug BOOKKEEPER-95.
https://issues.apache.org/jira/browse/BOOKKEEPER-95
Diffs
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/jmx/BKMBeanInfo.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/jmx/BKMBeanRegistry.java PRE-CREATION
Diff: https://reviews.apache.org/r/3451/diff
Testing
-------
Thanks,
Sijie
> extends zookeeper JMX to monitor and manage bookie server
> ---------------------------------------------------------
>
> Key: BOOKKEEPER-95
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-95
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-95.patch, BOOKKEEPER-95.patch
>
>
> we can extends/reuses zookeeper JMX until to monitor and manage bookie server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-95) extends zookeeper JMX to monitor
and manage bookie server
Posted by "Sijie Guo (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-95:
--------------------------------
Attachment: BOOKKEEPER-95.patch
rebase trunk
> extends zookeeper JMX to monitor and manage bookie server
> ---------------------------------------------------------
>
> Key: BOOKKEEPER-95
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-95
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Attachments: BOOKKEEPER-95.patch, BOOKKEEPER-95.patch
>
>
> we can extends/reuses zookeeper JMX until to monitor and manage bookie server
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira