[GitHub] [mynewt-core] brianwyld opened a new pull request #2106: PR for 3 changes : NDEBUG build, fix SPI on STM32, bitbang uart tx only

[GitBox <gi...@apache.org>]

brianwyld opened a new pull request #2106: PR for 3 changes : NDEBUG build, fix SPI on STM32, bitbang uart tx only
URL: https://github.com/apache/mynewt-core/pull/2106
 
 
   NDEBUG: currently mynewt-core fails to compile due to warnings when NDEBUG is defined (to create release version of code normally). This is because of:
    - assert() not being defined (leading to 'unused variable warnings')
    - assert.h not pulling in os/mynewt.h
    - non-definition of assert(0) meaning no return value for certain functions
   
   SPI: in the STM32 code there is a 'weak' spi init function which should be overriden in another file; gcc does not take this into account. Fix by #ifdefing out the base spi function.
   
   UART bitbang : 
    -allow use of this driver with only TX pin (remove syscfg test on the RX pin!=-1)
    - make its initialisation explicit by creation of the driver, rather than in pkg.yml which can't be overriden

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services