[jira] [Commented] (MAPREDUCE-5045) UtilTest#isCygwin method appears to be unused

["Harsh J (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14899963#comment-14899963 ] 

Harsh J commented on MAPREDUCE-5045:
------------------------------------

+1 lgtm, checked also for any existing use of it in trunk, and in branch-2, and found none. Can be safely removed.

Will commit after Jenkins +1.

> UtilTest#isCygwin method appears to be unused
> ---------------------------------------------
>
>                 Key: MAPREDUCE-5045
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5045
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: contrib/streaming, test
>    Affects Versions: 3.0.0
>            Reporter: Chris Nauroth
>            Assignee: Neelesh Srinivas Salian
>            Priority: Trivial
>              Labels: newbie
>         Attachments: MAPREDUCE-5045.001.patch
>
>
> Method {{UtilTest#isCygwin}} in /hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/UtilTest.java appears to be unused.  If so, then we need to remove it.  If anything is calling it, then we need to update the naming to isWindows, or perhaps just change call sites to use {{Shell#WINDOWS}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)