You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/25 12:48:18 UTC

[GitHub] [dubbo-go] cjphaha opened a new pull request #1483: Ftr: add fatal method for logger(1.5 branch)

cjphaha opened a new pull request #1483:
URL: https://github.com/apache/dubbo-go/pull/1483


   * Logger 接口添加 fatal 和 fatalf 方法


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] cjphaha commented on a change in pull request #1483: Ftr: add fatal method for logger(1.5 branch)

Posted by GitBox <gi...@apache.org>.
cjphaha commented on a change in pull request #1483:
URL: https://github.com/apache/dubbo-go/pull/1483#discussion_r721929410



##########
File path: common/logger/logger_test.go
##########
@@ -19,15 +19,21 @@ package logger
 
 import (
 	"fmt"
+	"os"
 	"path/filepath"
 	"runtime"
 	"testing"
 )
 
 import (
+	"bou.ke/monkey"

Review comment:
       参考这里的解决办法 https://stackoverflow.com/a/33404435/14335149 在单测中重新调用单测，可以对 Fatal 这种内部调用了 os.Exit(1) 的方法进行单测（不会导致 ut 失败），相比较于 monkey 更简单一些，。




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1483: Ftr: add fatal method for logger(1.5 branch)

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1483:
URL: https://github.com/apache/dubbo-go/pull/1483#discussion_r720645669



##########
File path: common/logger/logger_test.go
##########
@@ -19,15 +19,21 @@ package logger
 
 import (
 	"fmt"
+	"os"
 	"path/filepath"
 	"runtime"
 	"testing"
 )
 
 import (
+	"bou.ke/monkey"

Review comment:
       确定一下，这个依赖会不会造成ut 失败 @cjphaha 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1483: Ftr: add fatal method for logger(1.5 branch)

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1483:
URL: https://github.com/apache/dubbo-go/pull/1483#issuecomment-927876754


   这个pr要想ci通过，需要删掉1.5 samples的GOPROXY，看有空搞下没


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1483: Ftr: add fatal method for logger(1.5 branch)

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1483:
URL: https://github.com/apache/dubbo-go/pull/1483#issuecomment-934108528


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1483?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1483](https://codecov.io/gh/apache/dubbo-go/pull/1483?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c846c12) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/d3d437bb06550795a3458c8de541b25abd8512f3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3d437b) will **increase** coverage by `0.91%`.
   > The diff coverage is `12.93%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1483/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1483?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1483      +/-   ##
   ==========================================
   + Coverage   54.87%   55.78%   +0.91%     
   ==========================================
     Files         278      279       +1     
     Lines       15935    16037     +102     
   ==========================================
   + Hits         8744     8947     +203     
   + Misses       6266     6148     -118     
   - Partials      925      942      +17     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1483?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [common/extension/config\_load\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfbG9hZF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [common/logger/logger.go](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnZXIuZ28=) | `92.75% <ø> (ø)` | |
   | [common/logger/logging.go](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnaW5nLmdv) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `57.30% <0.00%> (+1.86%)` | :arrow_up: |
   | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `55.46% <71.42%> (+0.18%)` | :arrow_up: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.79% <83.33%> (-1.33%)` | :arrow_down: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `70.96% <83.33%> (-1.08%)` | :arrow_down: |
   | [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `35.61% <0.00%> (-0.69%)` | :arrow_down: |
   | [protocol/invocation/rpcinvocation.go](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvaW52b2NhdGlvbi9ycGNpbnZvY2F0aW9uLmdv) | `16.66% <0.00%> (-0.61%)` | :arrow_down: |
   | ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1483?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1483?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3c2aaf3...c846c12](https://codecov.io/gh/apache/dubbo-go/pull/1483?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter commented on pull request #1483: Ftr: add fatal method for logger(1.5 branch)

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1483:
URL: https://github.com/apache/dubbo-go/pull/1483#issuecomment-934108528


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1483?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1483](https://codecov.io/gh/apache/dubbo-go/pull/1483?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0d523ce) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/d3d437bb06550795a3458c8de541b25abd8512f3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3d437b) will **increase** coverage by `0.69%`.
   > The diff coverage is `16.37%`.
   
   > :exclamation: Current head 0d523ce differs from pull request most recent head c846c12. Consider uploading reports for the commit c846c12 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1483/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1483?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1483      +/-   ##
   ==========================================
   + Coverage   54.87%   55.57%   +0.69%     
   ==========================================
     Files         278      279       +1     
     Lines       15935    16159     +224     
   ==========================================
   + Hits         8744     8980     +236     
   + Misses       6266     6233      -33     
   - Partials      925      946      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1483?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [common/extension/config\_load\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfbG9hZF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [common/logger/logger.go](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnZXIuZ28=) | `92.75% <ø> (ø)` | |
   | [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `57.30% <0.00%> (+1.86%)` | :arrow_up: |
   | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `55.46% <71.42%> (+0.18%)` | :arrow_up: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.79% <83.33%> (-1.33%)` | :arrow_down: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `70.96% <83.33%> (-1.08%)` | :arrow_down: |
   | [common/logger/logging.go](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnaW5nLmdv) | `100.00% <100.00%> (ø)` | |
   | [metadata/report/nacos/report.go](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L25hY29zL3JlcG9ydC5nbw==) | `9.30% <0.00%> (-62.80%)` | :arrow_down: |
   | [remoting/nacos/builder.go](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvbmFjb3MvYnVpbGRlci5nbw==) | `42.64% <0.00%> (-39.02%)` | :arrow_down: |
   | [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `62.50% <0.00%> (-37.50%)` | :arrow_down: |
   | ... and [14 more](https://codecov.io/gh/apache/dubbo-go/pull/1483/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1483?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1483?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3c2aaf3...c846c12](https://codecov.io/gh/apache/dubbo-go/pull/1483?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks merged pull request #1483: Ftr: add fatal method for logger(1.5 branch)

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1483:
URL: https://github.com/apache/dubbo-go/pull/1483


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] cjphaha commented on a change in pull request #1483: Ftr: add fatal method for logger(1.5 branch)

Posted by GitBox <gi...@apache.org>.
cjphaha commented on a change in pull request #1483:
URL: https://github.com/apache/dubbo-go/pull/1483#discussion_r721929410



##########
File path: common/logger/logger_test.go
##########
@@ -19,15 +19,21 @@ package logger
 
 import (
 	"fmt"
+	"os"
 	"path/filepath"
 	"runtime"
 	"testing"
 )
 
 import (
+	"bou.ke/monkey"

Review comment:
       新的 commit 参考这里的解决办法 https://stackoverflow.com/a/33404435/14335149 在单测中重新调用单测，可以对 Fatal 这种内部调用了 os.Exit(1) 的方法进行单测（不会导致 ut 失败），相比较于 monkey 更简单一些。




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org