You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/18 19:42:43 UTC
[GitHub] [pulsar-client-node] gaoran10 opened a new pull request #169: [Build] Add windows building configurations
gaoran10 opened a new pull request #169:
URL: https://github.com/apache/pulsar-client-node/pull/169
# Motivation
Currently, building in windows needs some changes to do.
# Modification
Add windows building configurations in `binding.gyp`.
Add windows building-related doc in `README.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-node] codelipenghui merged pull request #169: [Build] Add windows building configurations
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #169:
URL: https://github.com/apache/pulsar-client-node/pull/169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-node] ryansealy commented on pull request #169: [WIP][Build] Add windows building configurations
Posted by GitBox <gi...@apache.org>.
ryansealy commented on pull request #169:
URL: https://github.com/apache/pulsar-client-node/pull/169#issuecomment-901582109
Could you make the PULSAR_CPP_PATH overridable by environment variable? When building in CI/CD environment it may not always be easy to work in C:\pulsar root for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-node] gaoran10 commented on pull request #169: [WIP][Build] Add windows building configurations
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #169:
URL: https://github.com/apache/pulsar-client-node/pull/169#issuecomment-901647147
@ryansealy Yes, I'll try to use an environment variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-node] codelipenghui commented on pull request #169: [Build] Add windows building configurations
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #169:
URL: https://github.com/apache/pulsar-client-node/pull/169#issuecomment-906843727
@ryansealy @Anonymitaet Could you please help review the PR again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-node] ryansealy commented on a change in pull request #169: [WIP][Build] Add windows building configurations
Posted by GitBox <gi...@apache.org>.
ryansealy commented on a change in pull request #169:
URL: https://github.com/apache/pulsar-client-node/pull/169#discussion_r691760233
##########
File path: binding.gyp
##########
@@ -18,14 +18,24 @@
#
{
+ 'conditions': [
+ ['OS=="win"', {
+ 'variables': {
+ 'PULSAR_CPP_PATH%': 'C:\pulsar\pulsar-client-cpp',
Review comment:
This may be a typo having trailing %
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-node] ryansealy edited a comment on pull request #169: [WIP][Build] Add windows building configurations
Posted by GitBox <gi...@apache.org>.
ryansealy edited a comment on pull request #169:
URL: https://github.com/apache/pulsar-client-node/pull/169#issuecomment-901582109
Can the PULSAR_CPP_PATH be overridable by environment variable? When building in CI/CD environment it may not always be easy to work in C:\pulsar root for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-node] ryansealy edited a comment on pull request #169: [WIP][Build] Add windows building configurations
Posted by GitBox <gi...@apache.org>.
ryansealy edited a comment on pull request #169:
URL: https://github.com/apache/pulsar-client-node/pull/169#issuecomment-901582109
Can the PULSAR_CPP_PATH overridable by environment variable? When building in CI/CD environment it may not always be easy to work in C:\pulsar root for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-node] Anonymitaet commented on a change in pull request #169: [Build] Add windows building configurations
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #169:
URL: https://github.com/apache/pulsar-client-node/pull/169#discussion_r695336948
##########
File path: README.md
##########
@@ -52,6 +52,17 @@ If an incompatible version of the C++ client is installed, you may fail to build
## How to install
+### Install in windows
Review comment:
```suggestion
### Install on windows
```
##########
File path: README.md
##########
@@ -52,6 +52,17 @@ If an incompatible version of the C++ client is installed, you may fail to build
## How to install
+### Install in windows
+
+You need to clone the Pulsar repo and build the Pulsar c++ client in windows, refer to https://pulsar.apache.org/docs/en/next/client-libraries-cpp/.
+
+After building pulsar-client-cpp, you could open windows cmd tool, and using the pulsar-client-cpp path to set the variable `PULSAR_CPP_DIR`.
Review comment:
```suggestion
3. Set the variable `PULSAR_CPP_DIR` with the `pulsar-client-cpp` path in a Windows command tool.
```
##########
File path: README.md
##########
@@ -52,6 +52,17 @@ If an incompatible version of the C++ client is installed, you may fail to build
## How to install
+### Install in windows
+
+You need to clone the Pulsar repo and build the Pulsar c++ client in windows, refer to https://pulsar.apache.org/docs/en/next/client-libraries-cpp/.
+
+After building pulsar-client-cpp, you could open windows cmd tool, and using the pulsar-client-cpp path to set the variable `PULSAR_CPP_DIR`.
+
+Open windows cmd tool and set the variable `PULSAR_CPP_DIR`, for example.
Review comment:
delete this since it is duplicated with the previous sentence?
##########
File path: README.md
##########
@@ -52,6 +52,17 @@ If an incompatible version of the C++ client is installed, you may fail to build
## How to install
+### Install in windows
+
+You need to clone the Pulsar repo and build the Pulsar c++ client in windows, refer to https://pulsar.apache.org/docs/en/next/client-libraries-cpp/.
+
+After building pulsar-client-cpp, you could open windows cmd tool, and using the pulsar-client-cpp path to set the variable `PULSAR_CPP_DIR`.
+
+Open windows cmd tool and set the variable `PULSAR_CPP_DIR`, for example.
+```shell
+set PULSAR_CPP_DIR=C:\pulsar\pulsar-client-cpp
+```
+
### Please install pulsar-client in your project:
Review comment:
```suggestion
### Install pulsar-client to your project
```
##########
File path: README.md
##########
@@ -52,6 +52,17 @@ If an incompatible version of the C++ client is installed, you may fail to build
## How to install
+### Install in windows
+
+You need to clone the Pulsar repo and build the Pulsar c++ client in windows, refer to https://pulsar.apache.org/docs/en/next/client-libraries-cpp/.
Review comment:
```suggestion
1. [Start Pulsar](https://pulsar.apache.org/docs/en/next/standalone/).
2. [Build the Pulsar C++ client on windows](https://pulsar.apache.org/docs/en/next/client-libraries-cpp/).
```
do you mean this?
##########
File path: README.md
##########
@@ -52,6 +52,17 @@ If an incompatible version of the C++ client is installed, you may fail to build
## How to install
+### Install in windows
+
+You need to clone the Pulsar repo and build the Pulsar c++ client in windows, refer to https://pulsar.apache.org/docs/en/next/client-libraries-cpp/.
+
+After building pulsar-client-cpp, you could open windows cmd tool, and using the pulsar-client-cpp path to set the variable `PULSAR_CPP_DIR`.
+
+Open windows cmd tool and set the variable `PULSAR_CPP_DIR`, for example.
Review comment:
```suggestion
```
##########
File path: README.md
##########
@@ -72,6 +83,8 @@ $ cd pulsar-client-node
$ npm install
```
+> (Notice: If you build pulsar-client-node in windows,you need to set the variable `PULSAR_CPP_DIR` first, and run the command `npm install` in cmd tool)
Review comment:
```suggestion
> **Note**
>
> If you build `pulsar-client-node on` windows, you need to set the variable `PULSAR_CPP_DIR` first and then install npm (run the command `npm install`) later in a Windows command-line tool.
```
do you mean this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org