You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by guoxiaolongzte <gi...@git.apache.org> on 2017/04/11 11:07:33 UTC

[GitHub] spark pull request #17608: [SPARK-20293][WEB UI][History]In the page of 'job...

GitHub user guoxiaolongzte opened a pull request:

    https://github.com/apache/spark/pull/17608

    [SPARK-20293][WEB UI][History]In the page of 'jobs' or 'stages' of history server web ui,,click the 'Go' button, query paging data, the page error

    ## What changes were proposed in this pull request?
    
    In the page of 'jobs' or 'stages' of history server web ui,
    Click on the 'Go' button, query paging data, the page error, function can not be used.
    The reasons are as follows:
    '#' Was escaped by the browser as% 23.
    & CompletedStage.desc = true% 23completed, the parameter value desc becomes = true% 23, causing the page to report an error. The error is as follows:
    HTTP ERROR 400
    Problem Access / history / app-20170411132432-0004 / stages /. Reason:
         For input string: "true # completed"
    Powered by Jetty: //
    The amendments are as follows:
    The URL of the accessed URL is escaped to ensure that the URL is not escaped by the browser.
    please see attachment of 'https://issues.apache.org/jira/browse/SPARK-20293'.
    
    ## How was this patch tested?
    
    manual tests
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guoxiaolongzte/spark SPARK-20293

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17608.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17608
    
----
commit d383efba12c66addb17006dea107bb0421d50bc3
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date:   2017-03-31T13:57:09Z

    [SPARK-20177]Document about compression way has some little detail changes.

commit 3059013e9d2aec76def14eb314b6761bea0e7ca0
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date:   2017-04-01T01:38:02Z

    [SPARK-20177] event log add a space

commit 555cef88fe09134ac98fd0ad056121c7df2539aa
Author: guoxiaolongzte <gu...@zte.com.cn>
Date:   2017-04-02T00:16:08Z

    '/applications/[app-id]/jobs' in rest api,status should be [running|succeeded|failed|unknown]

commit 46bb1ad3ddd9fb55b5607ac4f20213a90186cfe9
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date:   2017-04-05T03:16:50Z

    Merge branch 'master' of https://github.com/apache/spark into SPARK-20177

commit 0efb0dd9e404229cce638fe3fb0c966276784df7
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date:   2017-04-05T03:47:53Z

    [SPARK-20218]'/applications/[app-id]/stages' in REST API,add description.

commit 0e37fdeee28e31fc97436dabd001d3c85c5a7794
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date:   2017-04-05T05:22:54Z

    [SPARK-20218] '/applications/[app-id]/stages/[stage-id]' in REST API,remove redundant description.

commit 52641bb01e55b48bd9e8579fea217439d14c7dc7
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date:   2017-04-07T06:24:58Z

    Merge branch 'SPARK-20218'

commit d3977c9cab0722d279e3fae7aacbd4eb944c22f6
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date:   2017-04-08T07:13:02Z

    Merge branch 'master' of https://github.com/apache/spark

commit 137b90e5a85cde7e9b904b3e5ea0bb52518c4716
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date:   2017-04-10T05:13:40Z

    Merge branch 'master' of https://github.com/apache/spark

commit 0fe5865b8022aeacdb2d194699b990d8467f7a0a
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date:   2017-04-10T10:25:22Z

    Merge branch 'SPARK-20190' of https://github.com/guoxiaolongzte/spark

commit cf6f42ac84466960f2232c025b8faeb5d7378fe1
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date:   2017-04-10T10:26:27Z

    Merge branch 'master' of https://github.com/apache/spark

commit 9c1d634b9efe7cdd85e80d742e269aa69fd9994d
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date:   2017-04-11T06:38:01Z

    Merge branch 'master' of https://github.com/apache/spark

commit 6c62262bebe5fc8d5473b7fcc2fdb2656e4f8cc0
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date:   2017-04-11T10:46:58Z

    Merge branch 'master' of https://github.com/apache/spark

commit 1b22cfb8e13918d52a498e8d46b3a0c5c236d121
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date:   2017-04-11T11:03:01Z

    [SPARK-20293]In the page of 'jobs' or 'stages' of history server web ui,,click the 'Go' button, query paging data, the page error

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    It sounds a different issue with this. If it is a question, maybe, it might be better to ask a question to mailing list first before opening a JIRA. If it is really an issue, it might be better to report it with description, snaptops and steps to reproduce like I did above https://github.com/apache/spark/pull/17608#issuecomment-294059200 and https://github.com/apache/spark/pull/17608#issuecomment-293771070
    
    It seems a warning not an error BTW.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by ajbozarth <gi...@git.apache.org>.
Github user ajbozarth commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    On a quick git blame this is my code that seems to be broken. I'll take a more detailed look when I can in the next couple days.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    @ajbozarth @HyukjinKwon   I have added the PR description again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    @ajbozarth 
    @HyukjinKwon 
    OK.thanks. I will close this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by ajbozarth <gi...@git.apache.org>.
Github user ajbozarth commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    So I'm still not able to recreate this, I'm unsure how the Go button is creating the url you have, the issue here is for some reason `#completed` is being inserted in the middle of the url where it's not supposed to be and the extra `#` is being encoded and causing you issues. I'm not sure this is a good fix, but we should figure out why your history server is adding the extra `#completed` to the middle of your url and not mine and fix that.
    
    In order to help me figure out why our results are difference could you do an inspect on the Go button on your stage page and attach a screenshot? This is what mine looks like:
    ![screen shot 2017-04-13 at 2 17 25 pm](https://cloud.githubusercontent.com/assets/13952758/25024751/0991a5a8-2054-11e7-8570-4a80e919ecfa.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    I can reproduce this bug by the following steps provided in the JIRA - https://issues.apache.org/jira/secure/attachment/12862828/jobs.png and https://issues.apache.org/jira/secure/attachment/12862829/stages.png
    
    **Chrome**
    
    ![2017-04-13 12 37 17](https://cloud.githubusercontent.com/assets/6477701/24989243/37a64ed4-2046-11e7-9e01-8f63c725aad3.png)
    ![2017-04-13 12 37 29](https://cloud.githubusercontent.com/assets/6477701/24989244/37d025ec-2046-11e7-9714-cd071e641c8f.png)
    
    
    **Safari**
    
    ![2017-04-13 12 39 42](https://cloud.githubusercontent.com/assets/6477701/24989263/529dc5e6-2046-11e7-9614-3c656fdc1245.png)
    ![2017-04-13 12 39 34](https://cloud.githubusercontent.com/assets/6477701/24989264/529e97d2-2046-11e7-8362-b6a04687d27b.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by ajbozarth <gi...@git.apache.org>.
Github user ajbozarth commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    @guoxiaolongzte This seems familiar, are you using the latest version of Knox with your Spark UI?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    > maybe you can show a more concrete example of the URL as generated by the UI, and exactly what it is interpreted as, and the error page. This isn't very clear now.
    
    +1. @guoxiaolongzte do you mind if I ask to fill up the PR description with them? I think UI changes require before/after snapshots.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    @guoxiaolongzte I assume your Java version is 7. I think we dropped the support of Java 7 (https://issues.apache.org/jira/browse/SPARK-19493). We are able to build this on Windows but there are additional settings needed (e.g., memory for maven).
    
    (FYI, I was able to build Spark on Windows 7 with 32 bits before and we are building it Windows server 2012 64 bits via AppVeyor up to my knowledge.)
    
    @ajbozarth, thank you for your time and effort. I at least confirm that this issue is not reproducible in the current master. @guoxiaolongzte Let's close this. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by ajbozarth <gi...@git.apache.org>.
Github user ajbozarth commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    After seeing @HyukjinKwon inspector I tracked down the issue and found #16953 that fixed this in master and 2.1 already. It was such a tiny pr I forgot all about it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    I am trying hard to test it in apache master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by ajbozarth <gi...@git.apache.org>.
Github user ajbozarth commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    Thanks for the followup @guoxiaolongzte and @HyukjinKwon I'll take another look at work tomorrow. Also for clarification, the reason I'm being extra detailed about this is because I want to make sure this fix isn't just a band-aid solution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    @HyukjinKwon 
    **Now build the apache master is error.**
    
    [INFO] Compiling 73 Java sources to /home/spark_build/spark-2.1.0/common/network-common/target/scala-2.11/classes...
    [ERROR] /home/spark_build/spark-2.1.0/common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java:144: \u9519\u8bef: \u975e\u6cd5\u7684\u8868\u8fbe\u5f0f\u5f00\u59cb
    [ERROR]     channel.writeAndFlush(new ChunkFetchRequest(streamChunkId)).addListener(future -> {
    [ERROR]                                                                                     ^
    [ERROR] /home/spark_build/spark-2.1.0/common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java:144: \u9519\u8bef: \u975e\u6cd5\u7684\u8868\u8fbe\u5f0f\u5f00\u59cb
    [ERROR]     channel.writeAndFlush(new ChunkFetchRequest(streamChunkId)).addListener(future -> {
    [ERROR]                                                                                       ^
    [ERROR] /home/spark_build/spark-2.1.0/common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java:144: \u9519\u8bef: \u9700\u8981';'
    [ERROR]     channel.writeAndFlush(new ChunkFetchRequest(streamChunkId)).addListener(future -> {
    [ERROR]                                                                                        ^
    [ERROR] /home/spark_build/spark-2.1.0/common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java:145: \u9519\u8bef: \u4e0d\u662f\u8bed\u53e5
    [ERROR]       if (future.isSuccess()) {
    [ERROR]          ^
    [ERROR] /home/spark_build/spark-2.1.0/common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java:145: \u9519\u8bef: \u9700\u8981';'
    [ERROR]       if (future.isSuccess()) {
    [ERROR]                              ^
    [ERROR] /home/spark_build/spark-2.1.0/common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java:151: \u9519\u8bef: \u6709 'if', \u4f46\u662f\u6ca1\u6709 'else'
    [ERROR]       } else {
    [ERROR]         ^
    [ERROR] /home/spark_build/spark-2.1.0/common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java:163: \u9519\u8bef: \u975e\u6cd5\u7684\u7c7b\u578b\u5f00\u59cb
    [ERROR]     });
    [ERROR]      ^


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    I just downloaded the latest spark master code to compile and install , test the problem, there are still bugs, the page is wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17608: [SPARK-20293][WEB UI][History]In the page of 'job...

Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte closed the pull request at:

    https://github.com/apache/spark/pull/17608


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by ajbozarth <gi...@git.apache.org>.
Github user ajbozarth commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    I attempted to recreate this with the latest code on Safari, Firefox and Chrome and everything worked fine for me. What browser/environment are you using that you see this issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by ajbozarth <gi...@git.apache.org>.
Github user ajbozarth commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    After taking another look I was mixing this bug up with another when I asked that


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    @ajbozarth, I am terribly sorry. I just realised that my classpath was pointing out Spark 2.1.0.... (I was testing regressions.....).
    
    At that time it was as below:
    
    ### Spark 2.1.0
    
    **Before GO button**
    
    ![2017-04-14 9 49 29](https://cloud.githubusercontent.com/assets/6477701/25029403/f48d14ae-20f7-11e7-93ea-27c7aa26b38f.png)
    
    **After GO button**
    
    ![2017-04-14 9 50 28](https://cloud.githubusercontent.com/assets/6477701/25029402/f48a8752-20f7-11e7-95af-5c4928654d6b.png)
    
    
    **Go button inspection**
    
    ![2017-04-14 9 51 01](https://cloud.githubusercontent.com/assets/6477701/25029404/f48d1ecc-20f7-11e7-96ac-9ec016e4d5c2.png)
    
    
     I just clean/package again and then retested this. I can't reproduce this as below in the current master
    
    
    ### Current Master
    
    **Before GO button**
    
    ![2017-04-14 9 54 12](https://cloud.githubusercontent.com/assets/6477701/25029451/645a5832-20f8-11e7-9960-05573f5318b0.png)
    
    **After GO button**
    
    ![2017-04-14 9 54 18](https://cloud.githubusercontent.com/assets/6477701/25029450/6459c552-20f8-11e7-91f2-f7fdf67e1dd7.png)
    
    **Go button inspection**
    
    ![2017-04-14 9 54 32](https://cloud.githubusercontent.com/assets/6477701/25029449/64594a82-20f8-11e7-9d07-28b2727461f5.png)
    
    
    I can't reproduce this now. I think we should close this. I apologise again ... 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    Browser is Chrome.
    Spark version is 2.1.0. 
    Must be History Server Web ui.
    My Url:
        http://10.43.183.120:18082/history/app-20170411132432-0004/jobs/?completedJob.prevPageSize=100&completedJob.sort=Job+Id&completedJob.desc=true%23completed&completedJob.page=1&completedJob.pageSize=100#completed
    
    
    Excuse me,Are you testing at the History Server Web Ui?
    
    Today,I try to recreate the latest Apache master code to test the bug.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    So how do I deal with this PR?@ajbozarth


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    @HyukjinKwon 
    Thank you again, and now windows machines can compile apache master.
    No my java version is 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    Is this, the only way to encode, will not let the browser to escape our special characters.The page will not be error.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    After replacing `%23` to `#`, it seems showing the contents correctly as below:
    ![2017-04-13 12 41 09](https://cloud.githubusercontent.com/assets/6477701/24989298/88fc6156-2046-11e7-8bab-86e8874b2e07.png)
    ![2017-04-13 12 41 13](https://cloud.githubusercontent.com/assets/6477701/24989299/89246e08-2046-11e7-91ba-b924a7a558e5.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    @HyukjinKwon 
    **I just replaced the spark-core_2.11-2.2.0-SNAPSHOT.jar
    Successfully start history server, but I click the Go button, now is error, the error log is as follows:**.
    
    
    17/04/14 13:21:33 WARN ServletHandler: /history/app-20170411132432-0004/1/jobs/
    scala.MatchError: java.lang.NoSuchMethodError: org.apache.spark.scheduler.TaskInfo.accumulables()Lscala/collection/mutable/ListBuffer; (of class java.lang.NoSuchMethodError)
    	at org.apache.spark.deploy.history.HistoryServer.org$apache$spark$deploy$history$HistoryServer$$loadAppUi(HistoryServer.scala:230)
    	at org.apache.spark.deploy.history.HistoryServer$$anon$1.doGet(HistoryServer.scala:86)
    	at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
    	at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
    	at org.spark_project.jetty.servlet.ServletHolder.handle(ServletHolder.java:812)
    	at org.spark_project.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:587)
    	at org.spark_project.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127)
    	at org.spark_project.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
    	at org.spark_project.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061)
    	at org.spark_project.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
    	at org.spark_project.jetty.servlets.gzip.GzipHandler.handle(GzipHandler.java:479)
    	at org.spark_project.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:215)
    	at org.spark_project.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
    	at org.spark_project.jetty.server.Server.handle(Server.java:499)
    	at org.spark_project.jetty.server.HttpChannel.handle(HttpChannel.java:311)
    	at org.spark_project.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)
    	at org.spark_project.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
    	at org.spark_project.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
    	at org.spark_project.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
    	at java.lang.Thread.run(Thread.java:745)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    @ajbozarth I am using the  latest  spark version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17608: [SPARK-20293][WEB UI][History]In the page of 'jobs' or '...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/17608
  
    I don't quite understand, in that you say that the problem was URL-encoding the URL, but the solution here is to URL-encode it again. Is that right? maybe you can show a more concrete example of the URL as generated by the UI, and exactly what it is interpreted as, and the error page. This isn't very clear now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org