[Impala-ASF-CR] IMPALA-9688: Support create iceberg table by impala

["wangsheng (Code Review)" <ge...@cloudera.org>]

wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/15797 )

Change subject: IMPALA-9688: Support create iceberg table by impala
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15797/11/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java:

http://gerrit.cloudera.org:8080/#/c/15797/11/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@60
PS11, Line 60:   public static final String ICEBERG_STORAGE_HANDLER =
             :       "com.expediagroup.hiveberg.IcebergStorageHandler";
> why do we need this? do we have a hiveberg dependency?
This is mainly for compatibility with hive query in future, just like KUDU_STORAGE_HANDLER, but it's useless now.



-- 
To view, visit http://gerrit.cloudera.org:8080/15797
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d85db4c904a8c758c4cfb4f19cfbdab7e6ea284
Gerrit-Change-Number: 15797
Gerrit-PatchSet: 11
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Sat, 02 May 2020 03:03:29 +0000
Gerrit-HasComments: Yes