You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by Taha Hafeez <ta...@gmail.com> on 2011/07/07 09:05:51 UTC

Patch for TAP5-1476

Hi

would really appreciate if somebody takes a look at the patch submitted by
me for

https://issues.apache.org/jira/browse/TAP5-1476

regards
Taha

Re: Patch for TAP5-1476

Posted by Taha Tapestry <ta...@gmail.com>.
Hi

The reason I was so impatient was not because I wanted my patch to get applied to tapestry soon but because I wanted to know my shortcomings so that I can improve upon them and submit better patches.

Well honestly there is another reason. I want to work on other issues but will have to create another workspace so that my patches don't get overlapped

Regards
Taha 

On Jul 12, 2011, at 7:02 PM, Massimo Lusetti <ml...@gmail.com> wrote:

> On Tue, Jul 12, 2011 at 3:14 PM, Denis Stepanov
> <de...@gmail.com> wrote:
> 
>> I can relate to your feeling, I had submitted two patches one almost three months ago and no response :) I don't feel motivated to try to contribute anymore.
> 
> But did you continue to use it? It sounds like a blackmail to me...
> 
> Cheers
> -- 
> Massimo
> http://meridio.blogspot.com
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: Patch for TAP5-1476

Posted by Massimo Lusetti <ml...@gmail.com>.
On Tue, Jul 12, 2011 at 3:14 PM, Denis Stepanov
<de...@gmail.com> wrote:

> I can relate to your feeling, I had submitted two patches one almost three months ago and no response :) I don't feel motivated to try to contribute anymore.

But did you continue to use it? It sounds like a blackmail to me...

Cheers
-- 
Massimo
http://meridio.blogspot.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: Patch for TAP5-1476

Posted by Mark <ma...@xeric.net>.
Don't forget there isa  tapestry mirror at GitHub.  It is a little
more trouble to deal with posting the patches, but it makes it easy to
use your own patches until they get included.

Mark

On Tue, Jul 12, 2011 at 9:11 AM, Denis Stepanov
<de...@gmail.com> wrote:
> I understand :),  it would be nice to have the easiest way to contribute, I can see how github is way ahead on it.
>
> Denis
>
> On Jul 12, 2011, at 3:19 PM, Thiago H. de Paula Figueiredo wrote:
>
>> On Tue, 12 Jul 2011 10:14:30 -0300, Denis Stepanov <de...@gmail.com> wrote:
>>
>>> I can relate to your feeling, I had submitted two patches one almost three months ago and no response :) I don't feel motivated to try to contribute anymore.
>>
>> Don't feel that way. It's not that the committers don't appreciate contributions: it's that they have a life outside Tapestry too. ;)
>>
>> --
>> Thiago H. de Paula Figueiredo
>> Independent Java, Apache Tapestry 5 and Hibernate consultant, developer, and instructor
>> Owner, Ars Machina Tecnologia da Informação Ltda.
>> http://www.arsmachina.com.br
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: Patch for TAP5-1476

Posted by Howard Lewis Ship <hl...@gmail.com>.
Just because there hasn't been action doesn't mean it isn't important.
 I'm going to look over your patch and use it or extend it. Patch
looked good, i.e., there were tests.  The API isn't quite what I want
... I don't see the value of returning the injected service, simply
invoking methods on the injected service should be sufficient.

On Tue, Jul 12, 2011 at 7:17 AM, Thiago H. de Paula Figueiredo
<th...@gmail.com> wrote:
> On Tue, 12 Jul 2011 11:11:33 -0300, Denis Stepanov
> <de...@gmail.com> wrote:
>
>> I understand :),  it would be nice to have the easiest way to contribute,
>> I can see how github is way ahead on it.
>
> The Tapestry contribution process is the Apache one and we can't really
> change it unless the framework leaves Apache.
>
> --
> Thiago H. de Paula Figueiredo
> Independent Java, Apache Tapestry 5 and Hibernate consultant, developer, and
> instructor
> Owner, Ars Machina Tecnologia da Informação Ltda.
> http://www.arsmachina.com.br
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>



-- 
Howard M. Lewis Ship

Creator of Apache Tapestry

The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!

(971) 678-5210
http://howardlewisship.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: Patch for TAP5-1476

Posted by "Thiago H. de Paula Figueiredo" <th...@gmail.com>.
On Tue, 12 Jul 2011 11:11:33 -0300, Denis Stepanov  
<de...@gmail.com> wrote:

> I understand :),  it would be nice to have the easiest way to  
> contribute, I can see how github is way ahead on it.

The Tapestry contribution process is the Apache one and we can't really  
change it unless the framework leaves Apache.

-- 
Thiago H. de Paula Figueiredo
Independent Java, Apache Tapestry 5 and Hibernate consultant, developer,  
and instructor
Owner, Ars Machina Tecnologia da Informação Ltda.
http://www.arsmachina.com.br

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: Patch for TAP5-1476

Posted by Denis Stepanov <de...@gmail.com>.
I understand :),  it would be nice to have the easiest way to contribute, I can see how github is way ahead on it.

Denis

On Jul 12, 2011, at 3:19 PM, Thiago H. de Paula Figueiredo wrote:

> On Tue, 12 Jul 2011 10:14:30 -0300, Denis Stepanov <de...@gmail.com> wrote:
> 
>> I can relate to your feeling, I had submitted two patches one almost three months ago and no response :) I don't feel motivated to try to contribute anymore.
> 
> Don't feel that way. It's not that the committers don't appreciate contributions: it's that they have a life outside Tapestry too. ;)
> 
> -- 
> Thiago H. de Paula Figueiredo
> Independent Java, Apache Tapestry 5 and Hibernate consultant, developer, and instructor
> Owner, Ars Machina Tecnologia da Informação Ltda.
> http://www.arsmachina.com.br


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: Patch for TAP5-1476

Posted by "Thiago H. de Paula Figueiredo" <th...@gmail.com>.
On Tue, 12 Jul 2011 10:14:30 -0300, Denis Stepanov  
<de...@gmail.com> wrote:

> I can relate to your feeling, I had submitted two patches one almost  
> three months ago and no response :) I don't feel motivated to try to  
> contribute anymore.

Don't feel that way. It's not that the committers don't appreciate  
contributions: it's that they have a life outside Tapestry too. ;)

-- 
Thiago H. de Paula Figueiredo
Independent Java, Apache Tapestry 5 and Hibernate consultant, developer,  
and instructor
Owner, Ars Machina Tecnologia da Informação Ltda.
http://www.arsmachina.com.br

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: Patch for TAP5-1476

Posted by Denis Stepanov <de...@gmail.com>.
I can relate to your feeling, I had submitted two patches one almost three months ago and no response :) I don't feel motivated to try to contribute anymore.

Denis


On Jul 12, 2011, at 1:25 AM, Taha Hafeez wrote:

> Somebody :)
> 
> regards
> Taha
> 
> On Fri, Jul 8, 2011 at 4:05 PM, Taha Hafeez <ta...@gmail.com>wrote:
> 
>> BTW this patch can also resolve two more issues
>> https://issues.apache.org/jira/browse/TAP5-1406 &
>> https://issues.apache.org/jira/browse/TAP5-1407
>> 
>> regards
>> Taha
>> 
>> On Thu, Jul 7, 2011 at 12:35 PM, Taha Hafeez <ta...@gmail.com>wrote:
>> 
>>> Hi
>>> 
>>> would really appreciate if somebody takes a look at the patch submitted by
>>> me for
>>> 
>>> https://issues.apache.org/jira/browse/TAP5-1476
>>> 
>>> regards
>>> Taha
>>> 
>>> 
>> 
>> 
>> --
>> regards
>> Tawus
>> tawus.wordpress.com
>> 
>> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: Patch for TAP5-1476

Posted by Ulrich Stärk <ul...@spielviel.de>.
First thing I noticed: You didn't grant a license to include your patches to the ASF. It's a radio
button at the bottom of the popup form that's opening when attaching a file.

Uli

On 12.07.2011 04:37, Taha Tapestry wrote:
> Hi Bob
>
> Sorry for being so impatient
>
> I already got a mail from one of the committers to be more patient. 
>
> Next time I promise to be more patient but don't expect me to be any less excited :)
>
> Thanks & Regards
> Taha 
>
> On Jul 12, 2011, at 7:46 AM, Bob Harner <bo...@gmail.com> wrote:
>
>> Taha,
>>
>> This one is outside of my area of expertise.  But I just wanted to say
>> that I'm sure the silence is a reflection of everybody being busy on
>> their own projects, not a verdict on your contributions, which have
>> been excellent.
>>
>> Hopefully one of the more senior committers will soon step forward and
>> take a look at your patches (or maybe nominate you as a committer).
>>
>> On Mon, Jul 11, 2011 at 7:25 PM, Taha Hafeez <ta...@gmail.com> wrote:
>>> Somebody :)
>>>
>>> regards
>>> Taha
>>>
>>> On Fri, Jul 8, 2011 at 4:05 PM, Taha Hafeez <ta...@gmail.com>wrote:
>>>
>>>> BTW this patch can also resolve two more issues
>>>> https://issues.apache.org/jira/browse/TAP5-1406 &
>>>> https://issues.apache.org/jira/browse/TAP5-1407
>>>>
>>>> regards
>>>> Taha
>>>>
>>>> On Thu, Jul 7, 2011 at 12:35 PM, Taha Hafeez <ta...@gmail.com>wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> would really appreciate if somebody takes a look at the patch submitted by
>>>>> me for
>>>>>
>>>>> https://issues.apache.org/jira/browse/TAP5-1476
>>>>>
>>>>> regards
>>>>> Taha
>>>>>
>>>>>
>>>>
>>>> --
>>>> regards
>>>> Tawus
>>>> tawus.wordpress.com
>>>>
>>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
>> For additional commands, e-mail: dev-help@tapestry.apache.org
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: Patch for TAP5-1476

Posted by Taha Tapestry <ta...@gmail.com>.
Hi Bob

Sorry for being so impatient

I already got a mail from one of the committers to be more patient. 

Next time I promise to be more patient but don't expect me to be any less excited :)

Thanks & Regards
Taha 

On Jul 12, 2011, at 7:46 AM, Bob Harner <bo...@gmail.com> wrote:

> Taha,
> 
> This one is outside of my area of expertise.  But I just wanted to say
> that I'm sure the silence is a reflection of everybody being busy on
> their own projects, not a verdict on your contributions, which have
> been excellent.
> 
> Hopefully one of the more senior committers will soon step forward and
> take a look at your patches (or maybe nominate you as a committer).
> 
> On Mon, Jul 11, 2011 at 7:25 PM, Taha Hafeez <ta...@gmail.com> wrote:
>> Somebody :)
>> 
>> regards
>> Taha
>> 
>> On Fri, Jul 8, 2011 at 4:05 PM, Taha Hafeez <ta...@gmail.com>wrote:
>> 
>>> BTW this patch can also resolve two more issues
>>> https://issues.apache.org/jira/browse/TAP5-1406 &
>>> https://issues.apache.org/jira/browse/TAP5-1407
>>> 
>>> regards
>>> Taha
>>> 
>>> On Thu, Jul 7, 2011 at 12:35 PM, Taha Hafeez <ta...@gmail.com>wrote:
>>> 
>>>> Hi
>>>> 
>>>> would really appreciate if somebody takes a look at the patch submitted by
>>>> me for
>>>> 
>>>> https://issues.apache.org/jira/browse/TAP5-1476
>>>> 
>>>> regards
>>>> Taha
>>>> 
>>>> 
>>> 
>>> 
>>> --
>>> regards
>>> Tawus
>>> tawus.wordpress.com
>>> 
>>> 
>> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: Patch for TAP5-1476

Posted by Bob Harner <bo...@gmail.com>.
Taha,

This one is outside of my area of expertise.  But I just wanted to say
that I'm sure the silence is a reflection of everybody being busy on
their own projects, not a verdict on your contributions, which have
been excellent.

Hopefully one of the more senior committers will soon step forward and
take a look at your patches (or maybe nominate you as a committer).

On Mon, Jul 11, 2011 at 7:25 PM, Taha Hafeez <ta...@gmail.com> wrote:
> Somebody :)
>
> regards
> Taha
>
> On Fri, Jul 8, 2011 at 4:05 PM, Taha Hafeez <ta...@gmail.com>wrote:
>
>> BTW this patch can also resolve two more issues
>> https://issues.apache.org/jira/browse/TAP5-1406 &
>> https://issues.apache.org/jira/browse/TAP5-1407
>>
>> regards
>> Taha
>>
>> On Thu, Jul 7, 2011 at 12:35 PM, Taha Hafeez <ta...@gmail.com>wrote:
>>
>>> Hi
>>>
>>> would really appreciate if somebody takes a look at the patch submitted by
>>> me for
>>>
>>> https://issues.apache.org/jira/browse/TAP5-1476
>>>
>>> regards
>>> Taha
>>>
>>>
>>
>>
>> --
>> regards
>> Tawus
>> tawus.wordpress.com
>>
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: Patch for TAP5-1476

Posted by Taha Hafeez <ta...@gmail.com>.
Somebody :)

regards
Taha

On Fri, Jul 8, 2011 at 4:05 PM, Taha Hafeez <ta...@gmail.com>wrote:

> BTW this patch can also resolve two more issues
> https://issues.apache.org/jira/browse/TAP5-1406 &
> https://issues.apache.org/jira/browse/TAP5-1407
>
> regards
> Taha
>
> On Thu, Jul 7, 2011 at 12:35 PM, Taha Hafeez <ta...@gmail.com>wrote:
>
>> Hi
>>
>> would really appreciate if somebody takes a look at the patch submitted by
>> me for
>>
>> https://issues.apache.org/jira/browse/TAP5-1476
>>
>> regards
>> Taha
>>
>>
>
>
> --
> regards
> Tawus
> tawus.wordpress.com
>
>

Re: Patch for TAP5-1476

Posted by Taha Hafeez <ta...@gmail.com>.
BTW this patch can also resolve two more issues
https://issues.apache.org/jira/browse/TAP5-1406 &
https://issues.apache.org/jira/browse/TAP5-1407

regards
Taha

On Thu, Jul 7, 2011 at 12:35 PM, Taha Hafeez <ta...@gmail.com>wrote:

> Hi
>
> would really appreciate if somebody takes a look at the patch submitted by
> me for
>
> https://issues.apache.org/jira/browse/TAP5-1476
>
> regards
> Taha
>
>


-- 
regards
Tawus
tawus.wordpress.com