You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/09/21 05:18:27 UTC
[GitHub] [phoenix] stoty commented on a change in pull request #1317: PHOENIX-6234 - Replace Guava with phoenix-thirdparty version in 4.x
stoty commented on a change in pull request #1317:
URL: https://github.com/apache/phoenix/pull/1317#discussion_r712698569
##########
File path: phoenix-pherf/pom.xml
##########
@@ -118,6 +123,7 @@
<dependency>
<groupId>org.apache.tephra</groupId>
<artifactId>tephra-core</artifactId>
+ <version>${tephra.version}</version>
Review comment:
This should already be dependencyMananged in the top pom
##########
File path: phoenix-server/pom.xml
##########
@@ -173,6 +173,7 @@
<dependency>
<groupId>org.apache.tephra</groupId>
<artifactId>tephra-core</artifactId>
+ <version>${tephra.version}</version>
Review comment:
The versions should be defined in the top project dependencyManagement section
(Why do we even have test dependencies in phoenix-server ? - that's a question for another day)
##########
File path: phoenix-core/pom.xml
##########
@@ -282,34 +282,35 @@
</dependency>
<!-- Transaction dependencies -->
+ <!--
<dependency>
<groupId>org.apache.tephra</groupId>
<artifactId>tephra-api</artifactId>
</dependency>
+ -->
<dependency>
<groupId>org.apache.tephra</groupId>
- <artifactId>tephra-core</artifactId>
+ <artifactId>tephra-core-shaded</artifactId>
</dependency>
<dependency>
<groupId>org.apache.tephra</groupId>
<artifactId>tephra-core</artifactId>
+ <version>${tephra.version}</version>
Review comment:
The versions should be defined in the top project dependencyManagement section
##########
File path: phoenix-core/pom.xml
##########
@@ -282,34 +282,35 @@
</dependency>
<!-- Transaction dependencies -->
+ <!--
<dependency>
<groupId>org.apache.tephra</groupId>
<artifactId>tephra-api</artifactId>
</dependency>
+ -->
<dependency>
<groupId>org.apache.tephra</groupId>
- <artifactId>tephra-core</artifactId>
+ <artifactId>tephra-core-shaded</artifactId>
</dependency>
<dependency>
<groupId>org.apache.tephra</groupId>
<artifactId>tephra-core</artifactId>
+ <version>${tephra.version}</version>
<type>test-jar</type>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.tephra</groupId>
<artifactId>tephra-hbase-compat-${tephra.hbase.compat.version}</artifactId>
+ <version>${tephra.version}</version>
Review comment:
The versions should be defined in the top project dependencyManagement section
##########
File path: phoenix-core/pom.xml
##########
@@ -282,34 +282,35 @@
</dependency>
<!-- Transaction dependencies -->
+ <!--
Review comment:
Nit: delete instead of commenting out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org