You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Yifan Gu <yi...@mesosphere.io> on 2014/06/26 08:24:12 UTC
Review Request 23001: Fix race condition in OrphanTasks test
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23001/
-----------------------------------------------------------
Review request for mesos, Adam B and Vinod Kone.
Bugs: MESOS-1543
https://issues.apache.org/jira/browse/MESOS-1543
Repository: mesos-git
Description
-------
Not fixed yet. Can't figure out why cannot catch the FUTURE_DISPATCH stuff..
Diffs
-----
src/tests/master_tests.cpp c498d33
Diff: https://reviews.apache.org/r/23001/diff/
Testing
-------
Thanks,
Yifan Gu
Re: Review Request 23001: Fix race condition in OrphanTasks test
Posted by Adam Bordelon <ad...@mesosphere.io>.
Probably because StartMaster() calls cluster.masters.start() which itself
already awaits on a FUTURE_DISPATCH(Master::_recover).
Do you really need to pause the clock that early?
On Wed, Jun 25, 2014 at 11:24 PM, Yifan Gu <yi...@mesosphere.io> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23001/
> Review request for mesos, Adam B and Vinod Kone.
> By Yifan Gu.
> *Bugs: * MESOS-1543 <https://issues.apache.org/jira/browse/MESOS-1543>
> *Repository: * mesos-git
> Description
>
> Not fixed yet. Can't figure out why cannot catch the FUTURE_DISPATCH stuff..
>
> Diffs
>
> - src/tests/master_tests.cpp (c498d33)
>
> View Diff <https://reviews.apache.org/r/23001/diff/>
>
Re: Review Request 23001: Fixed flaky OrphanTasks test.
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23001/
-----------------------------------------------------------
(Updated July 1, 2014, 6:23 p.m.)
Review request for mesos, Adam B and Vinod Kone.
Bugs: MESOS-1543
https://issues.apache.org/jira/browse/MESOS-1543
Repository: mesos-git
Description
-------
Added Clock::settle after StartMaster() to ensure the master finishes executing _recover().
Diffs (updated)
-----
src/tests/master_tests.cpp 4dc28f2
Diff: https://reviews.apache.org/r/23001/diff/
Testing
-------
/bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter=*OrphanTask*
Succeeded for 2000+ times.
Thanks,
Yifan Gu
Re: Review Request 23001: Fixed flaky OrphanTasks test.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23001/#review47046
-----------------------------------------------------------
src/tests/master_tests.cpp
<https://reviews.apache.org/r/23001/#comment82660>
Make sure to remove "DISABLED_" (and retest)
- Adam B
On July 1, 2014, 1:35 a.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23001/
> -----------------------------------------------------------
>
> (Updated July 1, 2014, 1:35 a.m.)
>
>
> Review request for mesos, Adam B and Vinod Kone.
>
>
> Bugs: MESOS-1543
> https://issues.apache.org/jira/browse/MESOS-1543
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added Clock::settle after StartMaster() to ensure the master finishes executing _recover().
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 4dc28f2
>
> Diff: https://reviews.apache.org/r/23001/diff/
>
>
> Testing
> -------
>
> /bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter=*OrphanTask*
>
> Succeeded for 2000+ times.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 23001: Fixed flaky OrphanTasks test.
Posted by Adam B <ad...@mesosphere.io>.
> On July 1, 2014, 1:41 a.m., Adam B wrote:
> > Ship It!
(pending actually enabling the test by removing "DISABLED_")
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23001/#review47045
-----------------------------------------------------------
On July 1, 2014, 1:35 a.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23001/
> -----------------------------------------------------------
>
> (Updated July 1, 2014, 1:35 a.m.)
>
>
> Review request for mesos, Adam B and Vinod Kone.
>
>
> Bugs: MESOS-1543
> https://issues.apache.org/jira/browse/MESOS-1543
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added Clock::settle after StartMaster() to ensure the master finishes executing _recover().
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 4dc28f2
>
> Diff: https://reviews.apache.org/r/23001/diff/
>
>
> Testing
> -------
>
> /bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter=*OrphanTask*
>
> Succeeded for 2000+ times.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 23001: Fixed flaky OrphanTasks test.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23001/#review47045
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On July 1, 2014, 1:35 a.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23001/
> -----------------------------------------------------------
>
> (Updated July 1, 2014, 1:35 a.m.)
>
>
> Review request for mesos, Adam B and Vinod Kone.
>
>
> Bugs: MESOS-1543
> https://issues.apache.org/jira/browse/MESOS-1543
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added Clock::settle after StartMaster() to ensure the master finishes executing _recover().
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 4dc28f2
>
> Diff: https://reviews.apache.org/r/23001/diff/
>
>
> Testing
> -------
>
> /bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter=*OrphanTask*
>
> Succeeded for 2000+ times.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 23001: Fixed flaky OrphanTasks test.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23001/#review47048
-----------------------------------------------------------
Patch looks great!
Reviews applied: [23001]
All tests passed.
- Mesos ReviewBot
On July 1, 2014, 8:35 a.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23001/
> -----------------------------------------------------------
>
> (Updated July 1, 2014, 8:35 a.m.)
>
>
> Review request for mesos, Adam B and Vinod Kone.
>
>
> Bugs: MESOS-1543
> https://issues.apache.org/jira/browse/MESOS-1543
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added Clock::settle after StartMaster() to ensure the master finishes executing _recover().
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 4dc28f2
>
> Diff: https://reviews.apache.org/r/23001/diff/
>
>
> Testing
> -------
>
> /bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter=*OrphanTask*
>
> Succeeded for 2000+ times.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 23001: Fixed flaky OrphanTasks test.
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23001/
-----------------------------------------------------------
(Updated July 1, 2014, 8:35 a.m.)
Review request for mesos, Adam B and Vinod Kone.
Bugs: MESOS-1543
https://issues.apache.org/jira/browse/MESOS-1543
Repository: mesos-git
Description
-------
Added Clock::settle after StartMaster() to ensure the master finishes executing _recover().
Diffs (updated)
-----
src/tests/master_tests.cpp 4dc28f2
Diff: https://reviews.apache.org/r/23001/diff/
Testing
-------
/bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter=*OrphanTask*
Succeeded for 2000+ times.
Thanks,
Yifan Gu
Re: Review Request 23001: Fixed flaky OrphanTasks test.
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23001/
-----------------------------------------------------------
(Updated July 1, 2014, 8:34 a.m.)
Review request for mesos, Adam B and Vinod Kone.
Summary (updated)
-----------------
Fixed flaky OrphanTasks test.
Bugs: MESOS-1543
https://issues.apache.org/jira/browse/MESOS-1543
Repository: mesos-git
Description
-------
Added Clock::settle after StartMaster() to ensure the master finishes executing _recover().
Diffs (updated)
-----
src/tests/master_tests.cpp 4dc28f2
Diff: https://reviews.apache.org/r/23001/diff/
Testing
-------
/bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter=*OrphanTask*
Succeeded for 2000+ times.
Thanks,
Yifan Gu
Re: Review Request 23001: Fix race condition in OrphanTasks test
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23001/
-----------------------------------------------------------
(Updated July 1, 2014, 8:32 a.m.)
Review request for mesos, Adam B and Vinod Kone.
Bugs: MESOS-1543
https://issues.apache.org/jira/browse/MESOS-1543
Repository: mesos-git
Description (updated)
-------
Added Clock::settle after StartMaster() to ensure the master finishes executing _recover().
Diffs (updated)
-----
src/tests/master_tests.cpp 4dc28f2
Diff: https://reviews.apache.org/r/23001/diff/
Testing (updated)
-------
/bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter=*OrphanTask*
Succeeded for 2000+ times.
Thanks,
Yifan Gu