You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "manuzhang (via GitHub)" <gi...@apache.org> on 2026/05/12 14:48:31 UTC
[PR] Build: Allow versioned PR title prefixes [iceberg]
manuzhang opened a new pull request, #16301:
URL: https://github.com/apache/iceberg/pull/16301
## Summary
- Allow the PR title check workflow to accept module prefixes with version tokens, such as `Flink 2.1: Add Tests`.
- Keep the existing `Module: Description` shape by still requiring a prefix, colon, space, and non-empty description.
- Update the failure examples to include a versioned Flink title.
## Testing
- `git diff --check -- .github/workflows/pr-title-check.yml`
- Local shell regex checks for valid and invalid PR title examples
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Allow versioned PR title prefixes [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #16301:
URL: https://github.com/apache/iceberg/pull/16301#discussion_r3227787705
##########
.github/workflows/pr-title-check.yml:
##########
@@ -34,10 +34,10 @@ jobs:
env:
PR_TITLE: ${{ github.event.pull_request.title }}
run: |
- PATTERN='^[A-Za-z][A-Za-z0-9._+/&-]*: .+'
+ PATTERN='^[A-Za-z][A-Za-z0-9._+/&-]*( [A-Za-z0-9][A-Za-z0-9._+/&-]*)*: .+'
Review Comment:
```suggestion
PATTERN='^(Revert ")?[A-Za-z][A-Za-z0-9._+/&,-]*( [A-Za-z0-9][A-Za-z0-9._+/&,-]*)*: .+'
```
1. added `,` to allow comma-separated modules like `API, Core:` or `Spark 3.4, 3.5, 4.0:`
2. added `(Revert ")?`, optional `Revert "` prefix so GitHub's auto-generated revert titles pass, ie `Revert "Build: Bump ...".`
##########
.github/workflows/pr-title-check.yml:
##########
@@ -34,10 +34,10 @@ jobs:
env:
PR_TITLE: ${{ github.event.pull_request.title }}
run: |
- PATTERN='^[A-Za-z][A-Za-z0-9._+/&-]*: .+'
+ PATTERN='^[A-Za-z][A-Za-z0-9._+/&-]*( [A-Za-z0-9][A-Za-z0-9._+/&-]*)*: .+'
if ! echo "$PR_TITLE" | grep -Eq "$PATTERN"; then
echo "::error::PR title must follow 'Module: Description' format. Got: '$PR_TITLE'"
- echo "Examples: 'Core: Fix ...', 'Spark: Add ...', 'API: Remove ...', 'Docs: Update ...'"
+ echo "Examples: 'Core: Fix ...', 'Spark: Add ...', 'Flink 2.1: Add ...', 'Docs: Update ...'"
Review Comment:
```suggestion
echo "Examples: 'Core: Fix ...', 'Spark: Add ...', 'Flink 2.1: Add ...', 'API, Core: Update ...'"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Improve PR title check pattern for multi-word prefixes and reverts [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #16301:
URL: https://github.com/apache/iceberg/pull/16301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org