You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/01/11 12:58:34 UTC

[GitHub] [calcite] vlsi commented on issue #1744: Move logging-related tests to src/loggingTest

vlsi commented on issue #1744: Move logging-related tests to src/loggingTest
URL: https://github.com/apache/calcite/pull/1744#issuecomment-573314788
 
 
   > Moves all the tests that needs loggings to another dir seems not that necessary
   
   Technically speaking, I find nothing wrong with implementing targeted tests in the `loggingTest` subfolder.
   
   I moved the full class for simplification purposes.
   However, it might make sense to extract a method that needs logging validation and put it to the respective location.
   
   It is more-or-less the same as we select package names for the classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services