You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by jun aoki <ju...@gmail.com> on 2014/10/23 20:40:28 UTC
Review Request 27103: AMBARI-7875 Docker build on builds.a.o and
support JDK1.6 and python2.6
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27103/
-----------------------------------------------------------
Review request for Ambari.
Bugs: AMBARI-7875
https://issues.apache.org/jira/browse/AMBARI-7875
Repository: ambari
Description
-------
Run Ambari build and test on Docker container.
This way, we have more flexibility for third party libraries and build environment.
Currently JDK 1.6 and Python 2.6 should be supported but
https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit/
runs on JDK1.7, which is a discrepancy.
Diffs
-----
dev-support/docker/README.md PRE-CREATION
dev-support/docker/docker/Dockerfile PRE-CREATION
dev-support/docker/docker/bin/ambaribuild.py PRE-CREATION
dev-support/docker/docker/blueprints/single-node-HDP-2.1-blueprint1.json PRE-CREATION
dev-support/docker/docker/blueprints/single-node-hostmapping1.json PRE-CREATION
Diff: https://reviews.apache.org/r/27103/diff/
Testing
-------
https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit-docker
Thanks,
jun aoki
Re: Review Request 27103: AMBARI-7875 Docker build on builds.a.o and
support JDK1.6 and python2.6
Posted by jun aoki <ju...@gmail.com>.
> On Oct. 23, 2014, 11:08 p.m., Alejandro Fernandez wrote:
> > dev-support/docker/docker/bin/ambaribuild.py, line 26
> > <https://reviews.apache.org/r/27103/diff/1/?file=730223#file730223line26>
> >
> > We should follow PEP8 style guide. functions_like_this variables_also_like_this
> >
> > And 2-space indents (even though PEP8 suggests 4)
Alejandro, thank you for your review. will fix them and re-submit.
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27103/#review58157
-----------------------------------------------------------
On Oct. 23, 2014, 6:40 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27103/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 6:40 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-7875
> https://issues.apache.org/jira/browse/AMBARI-7875
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Run Ambari build and test on Docker container.
> This way, we have more flexibility for third party libraries and build environment.
> Currently JDK 1.6 and Python 2.6 should be supported but
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit/
> runs on JDK1.7, which is a discrepancy.
>
>
> Diffs
> -----
>
> dev-support/docker/README.md PRE-CREATION
> dev-support/docker/docker/Dockerfile PRE-CREATION
> dev-support/docker/docker/bin/ambaribuild.py PRE-CREATION
> dev-support/docker/docker/blueprints/single-node-HDP-2.1-blueprint1.json PRE-CREATION
> dev-support/docker/docker/blueprints/single-node-hostmapping1.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27103/diff/
>
>
> Testing
> -------
>
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit-docker
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 27103: AMBARI-7875 Docker build on builds.a.o and
support JDK1.6 and python2.6
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27103/#review58157
-----------------------------------------------------------
dev-support/docker/docker/bin/ambaribuild.py
<https://reviews.apache.org/r/27103/#comment99080>
We should follow PEP8 style guide. functions_like_this variables_also_like_this
And 2-space indents (even though PEP8 suggests 4)
dev-support/docker/docker/bin/ambaribuild.py
<https://reviews.apache.org/r/27103/#comment99082>
Is it necessary for these functions to return the return code?
dev-support/docker/docker/bin/ambaribuild.py
<https://reviews.apache.org/r/27103/#comment99083>
Why not define these values as constants?
dev-support/docker/docker/bin/ambaribuild.py
<https://reviews.apache.org/r/27103/#comment99085>
We should follow the convention of a separate file for unit tests.
dev-support/docker/docker/bin/ambaribuild.py
<https://reviews.apache.org/r/27103/#comment99087>
All of these if-blocks should check the return codes of the processes before continuing.
- Alejandro Fernandez
On Oct. 23, 2014, 6:40 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27103/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 6:40 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-7875
> https://issues.apache.org/jira/browse/AMBARI-7875
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Run Ambari build and test on Docker container.
> This way, we have more flexibility for third party libraries and build environment.
> Currently JDK 1.6 and Python 2.6 should be supported but
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit/
> runs on JDK1.7, which is a discrepancy.
>
>
> Diffs
> -----
>
> dev-support/docker/README.md PRE-CREATION
> dev-support/docker/docker/Dockerfile PRE-CREATION
> dev-support/docker/docker/bin/ambaribuild.py PRE-CREATION
> dev-support/docker/docker/blueprints/single-node-HDP-2.1-blueprint1.json PRE-CREATION
> dev-support/docker/docker/blueprints/single-node-hostmapping1.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27103/diff/
>
>
> Testing
> -------
>
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit-docker
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 27103: AMBARI-7875 Docker build on builds.a.o and
support JDK1.6 and python2.6
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Oct. 25, 2014, 12:41 a.m., Alejandro Fernandez wrote:
> > Ship It!
What branch is this going in? We typically put the branch name in both the Jira and the reviewboard
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27103/#review58457
-----------------------------------------------------------
On Oct. 25, 2014, 12:35 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27103/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2014, 12:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-7875
> https://issues.apache.org/jira/browse/AMBARI-7875
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Run Ambari build and test on Docker container.
> This way, we have more flexibility for third party libraries and build environment.
> Currently JDK 1.6 and Python 2.6 should be supported but
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit/
> runs on JDK1.7, which is a discrepancy.
>
>
> Diffs
> -----
>
> dev-support/docker/README.md PRE-CREATION
> dev-support/docker/docker/Dockerfile PRE-CREATION
> dev-support/docker/docker/bin/__init__.py PRE-CREATION
> dev-support/docker/docker/bin/ambaribuild.py PRE-CREATION
> dev-support/docker/docker/bin/test/__init__.py PRE-CREATION
> dev-support/docker/docker/bin/test/ambaribuild_test.py PRE-CREATION
> dev-support/docker/docker/blueprints/single-node-HDP-2.1-blueprint1.json PRE-CREATION
> dev-support/docker/docker/blueprints/single-node-hostmapping1.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27103/diff/
>
>
> Testing
> -------
>
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit-docker
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 27103: AMBARI-7875 Docker build on builds.a.o and
support JDK1.6 and python2.6
Posted by jun aoki <ju...@gmail.com>.
> On Oct. 25, 2014, 12:41 a.m., Alejandro Fernandez wrote:
> > Ship It!
>
> Alejandro Fernandez wrote:
> What branch is this going in? We typically put the branch name in both the Jira and the reviewboard
Alejandro, thank you for pointing out. I forgot to add. It is trunk and branch-1.7.0. Will ask one more +1 from the community.
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27103/#review58457
-----------------------------------------------------------
On Oct. 25, 2014, 12:35 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27103/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2014, 12:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-7875
> https://issues.apache.org/jira/browse/AMBARI-7875
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Run Ambari build and test on Docker container.
> This way, we have more flexibility for third party libraries and build environment.
> Currently JDK 1.6 and Python 2.6 should be supported but
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit/
> runs on JDK1.7, which is a discrepancy.
>
>
> Diffs
> -----
>
> dev-support/docker/README.md PRE-CREATION
> dev-support/docker/docker/Dockerfile PRE-CREATION
> dev-support/docker/docker/bin/__init__.py PRE-CREATION
> dev-support/docker/docker/bin/ambaribuild.py PRE-CREATION
> dev-support/docker/docker/bin/test/__init__.py PRE-CREATION
> dev-support/docker/docker/bin/test/ambaribuild_test.py PRE-CREATION
> dev-support/docker/docker/blueprints/single-node-HDP-2.1-blueprint1.json PRE-CREATION
> dev-support/docker/docker/blueprints/single-node-hostmapping1.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27103/diff/
>
>
> Testing
> -------
>
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit-docker
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 27103: AMBARI-7875 Docker build on builds.a.o and
support JDK1.6 and python2.6
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27103/#review58457
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 25, 2014, 12:35 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27103/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2014, 12:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-7875
> https://issues.apache.org/jira/browse/AMBARI-7875
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Run Ambari build and test on Docker container.
> This way, we have more flexibility for third party libraries and build environment.
> Currently JDK 1.6 and Python 2.6 should be supported but
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit/
> runs on JDK1.7, which is a discrepancy.
>
>
> Diffs
> -----
>
> dev-support/docker/README.md PRE-CREATION
> dev-support/docker/docker/Dockerfile PRE-CREATION
> dev-support/docker/docker/bin/__init__.py PRE-CREATION
> dev-support/docker/docker/bin/ambaribuild.py PRE-CREATION
> dev-support/docker/docker/bin/test/__init__.py PRE-CREATION
> dev-support/docker/docker/bin/test/ambaribuild_test.py PRE-CREATION
> dev-support/docker/docker/blueprints/single-node-HDP-2.1-blueprint1.json PRE-CREATION
> dev-support/docker/docker/blueprints/single-node-hostmapping1.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27103/diff/
>
>
> Testing
> -------
>
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit-docker
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 27103: AMBARI-7875 Docker build on builds.a.o and
support JDK1.6 and python2.6
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27103/#review58471
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Oct. 25, 2014, 12:35 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27103/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2014, 12:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-7875
> https://issues.apache.org/jira/browse/AMBARI-7875
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Run Ambari build and test on Docker container.
> This way, we have more flexibility for third party libraries and build environment.
> Currently JDK 1.6 and Python 2.6 should be supported but
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit/
> runs on JDK1.7, which is a discrepancy.
>
>
> Diffs
> -----
>
> dev-support/docker/README.md PRE-CREATION
> dev-support/docker/docker/Dockerfile PRE-CREATION
> dev-support/docker/docker/bin/__init__.py PRE-CREATION
> dev-support/docker/docker/bin/ambaribuild.py PRE-CREATION
> dev-support/docker/docker/bin/test/__init__.py PRE-CREATION
> dev-support/docker/docker/bin/test/ambaribuild_test.py PRE-CREATION
> dev-support/docker/docker/blueprints/single-node-HDP-2.1-blueprint1.json PRE-CREATION
> dev-support/docker/docker/blueprints/single-node-hostmapping1.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27103/diff/
>
>
> Testing
> -------
>
> https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit-docker
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 27103: AMBARI-7875 Docker build on builds.a.o and
support JDK1.6 and python2.6
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27103/
-----------------------------------------------------------
(Updated Oct. 25, 2014, 12:35 a.m.)
Review request for Ambari.
Changes
-------
Applied Alejandro's feedback.
Bugs: AMBARI-7875
https://issues.apache.org/jira/browse/AMBARI-7875
Repository: ambari
Description
-------
Run Ambari build and test on Docker container.
This way, we have more flexibility for third party libraries and build environment.
Currently JDK 1.6 and Python 2.6 should be supported but
https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit/
runs on JDK1.7, which is a discrepancy.
Diffs (updated)
-----
dev-support/docker/README.md PRE-CREATION
dev-support/docker/docker/Dockerfile PRE-CREATION
dev-support/docker/docker/bin/__init__.py PRE-CREATION
dev-support/docker/docker/bin/ambaribuild.py PRE-CREATION
dev-support/docker/docker/bin/test/__init__.py PRE-CREATION
dev-support/docker/docker/bin/test/ambaribuild_test.py PRE-CREATION
dev-support/docker/docker/blueprints/single-node-HDP-2.1-blueprint1.json PRE-CREATION
dev-support/docker/docker/blueprints/single-node-hostmapping1.json PRE-CREATION
Diff: https://reviews.apache.org/r/27103/diff/
Testing
-------
https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit-docker
Thanks,
jun aoki