You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sachchidanand Vaidya <va...@juniper.net> on 2013/12/30 22:48:36 UTC
Review Request 16523: Unit tests for Juniper contrail VM Interface Model and
Instance Ip Model class.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16523/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
Added unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.
Diffs
-----
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/InstanceIpModelTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VMInterfaceModelTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/16523/diff/
Testing
-------
All Juniper contrail plugin unit tests pass without any error.
Thanks,
Sachchidanand Vaidya
Re: Review Request 16523: Unit tests for Juniper contrail VM Interface Model
and Instance Ip Model class.
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16523/#review33783
-----------------------------------------------------------
I don't think it will pass checkstyle yet, because of the
import <this or that>.*;
it is not permitted by our build. (and I don't like the typesafety implications of it.)
- daan Hoogland
On Feb. 5, 2014, 11:23 p.m., Sachchidanand Vaidya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16523/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2014, 11:23 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.
>
>
> Diffs
> -----
>
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/InstanceIpModelTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VMInterfaceModelTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16523/diff/
>
>
> Testing
> -------
>
> All Juniper contrail plugin unit tests pass without any error.
>
>
> Thanks,
>
> Sachchidanand Vaidya
>
>
Re: Review Request 16523: Unit tests for Juniper contrail VM Interface Model
and Instance Ip Model class.
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16523/#review42104
-----------------------------------------------------------
Ship it!
bd3ec50dea87b938929a5448ac83e8da154af1a7
- daan Hoogland
On April 18, 2014, 6:16 a.m., Sachchidanand Vaidya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16523/
> -----------------------------------------------------------
>
> (Updated April 18, 2014, 6:16 a.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.
>
>
> Diffs
> -----
>
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/InstanceIpModelTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/VMInterfaceModelTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16523/diff/
>
>
> Testing
> -------
>
> All Juniper contrail plugin unit tests pass without any error.
>
>
> Thanks,
>
> Sachchidanand Vaidya
>
>
Re: Review Request 16523: Unit tests for Juniper contrail VM Interface Model
and Instance Ip Model class.
Posted by Sachchidanand Vaidya <va...@juniper.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16523/
-----------------------------------------------------------
(Updated April 17, 2014, 11:16 p.m.)
Review request for cloudstack.
Changes
-------
Fixed checkstyle issues.
Repository: cloudstack-git
Description
-------
Added unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.
Diffs (updated)
-----
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/InstanceIpModelTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/VMInterfaceModelTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/16523/diff/
Testing
-------
All Juniper contrail plugin unit tests pass without any error.
Thanks,
Sachchidanand Vaidya
Re: Review Request 16523: Unit tests for Juniper contrail VM Interface Model
and Instance Ip Model class.
Posted by Sachchidanand Vaidya <va...@juniper.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16523/
-----------------------------------------------------------
(Updated Feb. 5, 2014, 11:23 p.m.)
Review request for cloudstack.
Changes
-------
Hi Daan,
I have updated files correcting some of the formatting. Pls let me know if this looks ok.
Thanks,
Sachin
Repository: cloudstack-git
Description
-------
Added unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.
Diffs (updated)
-----
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/InstanceIpModelTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VMInterfaceModelTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/16523/diff/
Testing
-------
All Juniper contrail plugin unit tests pass without any error.
Thanks,
Sachchidanand Vaidya
Re: Review Request 16523: Unit tests for Juniper contrail VM Interface Model
and Instance Ip Model class.
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16523/#review33581
-----------------------------------------------------------
sorry to bug you again but the tests give checkstyle errors. Can you fix these and resubmit?
- daan Hoogland
On Feb. 3, 2014, 10:15 p.m., Sachchidanand Vaidya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16523/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2014, 10:15 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.
>
>
> Diffs
> -----
>
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/InstanceIpModelTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VMInterfaceModelTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16523/diff/
>
>
> Testing
> -------
>
> All Juniper contrail plugin unit tests pass without any error.
>
>
> Thanks,
>
> Sachchidanand Vaidya
>
>
Re: Review Request 16523: Unit tests for Juniper contrail VM Interface Model
and Instance Ip Model class.
Posted by Sachchidanand Vaidya <va...@juniper.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16523/
-----------------------------------------------------------
(Updated Feb. 3, 2014, 10:15 p.m.)
Review request for cloudstack.
Changes
-------
Dann,
Thanks. I have updated the file with license header.
Best Regards,
Sachin
Repository: cloudstack-git
Description
-------
Added unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.
Diffs (updated)
-----
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/InstanceIpModelTest.java PRE-CREATION
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VMInterfaceModelTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/16523/diff/
Testing
-------
All Juniper contrail plugin unit tests pass without any error.
Thanks,
Sachchidanand Vaidya
Re: Review Request 16523: Unit tests for Juniper contrail VM Interface Model
and Instance Ip Model class.
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16523/#review33398
-----------------------------------------------------------
please add a license header to both files and resubmit
- daan Hoogland
On Dec. 30, 2013, 9:48 p.m., Sachchidanand Vaidya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16523/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2013, 9:48 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.
>
>
> Diffs
> -----
>
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/InstanceIpModelTest.java PRE-CREATION
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VMInterfaceModelTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16523/diff/
>
>
> Testing
> -------
>
> All Juniper contrail plugin unit tests pass without any error.
>
>
> Thanks,
>
> Sachchidanand Vaidya
>
>