You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/13 02:36:15 UTC

[GitHub] [incubator-gobblin] arjun4084346 opened a new pull request #2926: [GOBBLIN-1085] fix compaction initialization

arjun4084346 opened a new pull request #2926: [GOBBLIN-1085] fix compaction initialization
URL: https://github.com/apache/incubator-gobblin/pull/2926
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-XXX
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   CompactionSource::getWorkunitStream() copies the jars to hdfs and then datasetfinder tries to search for jars.
   
   This is a big waste of resources.
   
   We should find datasets first, and then, if any datasets are found, should upload jars.
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   trivial
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] yukuai518 commented on issue #2926: [GOBBLIN-1085] fix compaction initialization

Posted by GitBox <gi...@apache.org>.
yukuai518 commented on issue #2926: [GOBBLIN-1085] fix compaction initialization
URL: https://github.com/apache/incubator-gobblin/pull/2926#issuecomment-598909527
 
 
   +1 LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] asfgit closed pull request #2926: [GOBBLIN-1085] fix compaction initialization

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2926: [GOBBLIN-1085] fix compaction initialization
URL: https://github.com/apache/incubator-gobblin/pull/2926
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] codecov-io commented on issue #2926: [GOBBLIN-1085] fix compaction initialization

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2926: [GOBBLIN-1085] fix compaction initialization
URL: https://github.com/apache/incubator-gobblin/pull/2926#issuecomment-598527690
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2926?src=pr&el=h1) Report
   > Merging [#2926](https://codecov.io/gh/apache/incubator-gobblin/pull/2926?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/f3d75e392c554771e3c098cafb648ec55fa40ba7&el=desc) will **decrease** coverage by `0.41%`.
   > The diff coverage is `80.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2926/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc)](https://codecov.io/gh/apache/incubator-gobblin/pull/2926?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2926      +/-   ##
   ============================================
   - Coverage     45.87%   45.46%   -0.42%     
   + Complexity     9190     9107      -83     
   ============================================
     Files          1934     1936       +2     
     Lines         72931    73060     +129     
     Branches       8046     8052       +6     
   ============================================
   - Hits          33458    33217     -241     
   - Misses        36404    36781     +377     
   + Partials       3069     3062       -7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2926?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...he/gobblin/compaction/source/CompactionSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2926/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc291cmNlL0NvbXBhY3Rpb25Tb3VyY2UuamF2YQ==) | `72.68% <80.00%> (-0.38%)` | `14.00 <1.00> (ø)` | |
   | [...bblin/runtime/job\_monitor/KafkaAvroJobMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2926/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FBdnJvSm9iTW9uaXRvci5qYXZh) | `0.00% <0.00%> (-93.11%)` | `0.00% <0.00%> (-7.00%)` | |
   | [...pache/gobblin/runtime/kafka/HighLevelConsumer.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2926/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUva2Fma2EvSGlnaExldmVsQ29uc3VtZXIuamF2YQ==) | `0.00% <0.00%> (-81.04%)` | `0.00% <0.00%> (-12.00%)` | |
   | [...n/runtime/job\_monitor/SLAEventKafkaJobMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2926/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvU0xBRXZlbnRLYWZrYUpvYk1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-80.27%)` | `0.00% <0.00%> (-17.00%)` | |
   | [...blin/service/monitoring/KafkaJobStatusMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2926/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9LYWZrYUpvYlN0YXR1c01vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-72.23%)` | `0.00% <0.00%> (-16.00%)` | |
   | [...e/gobblin/runtime/job\_monitor/KafkaJobMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2926/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FKb2JNb25pdG9yLmphdmE=) | `0.00% <0.00%> (-65.22%)` | `0.00% <0.00%> (-9.00%)` | |
   | [.../service/monitoring/KafkaAvroJobStatusMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2926/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9LYWZrYUF2cm9Kb2JTdGF0dXNNb25pdG9yLmphdmE=) | `0.00% <0.00%> (-56.67%)` | `0.00% <0.00%> (-13.00%)` | |
   | [...he/gobblin/kafka/client/Kafka09ConsumerClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2926/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMDkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4va2Fma2EvY2xpZW50L0thZmthMDlDb25zdW1lckNsaWVudC5qYXZh) | `67.36% <0.00%> (-9.45%)` | `12.00% <0.00%> (+4.00%)` | :arrow_down: |
   | [...e/gobblin/runtime/app/ServiceBasedAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2926/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBwL1NlcnZpY2VCYXNlZEFwcExhdW5jaGVyLmphdmE=) | `43.68% <0.00%> (-5.83%)` | `12.00% <0.00%> (ø%)` | |
   | [...in/service/modules/core/GobblinServiceManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2926/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9jb3JlL0dvYmJsaW5TZXJ2aWNlTWFuYWdlci5qYXZh) | `52.24% <0.00%> (-4.50%)` | `18.00% <0.00%> (-7.00%)` | |
   | ... and [31 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2926/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2926?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2926?src=pr&el=footer). Last update [f3d75e3...8638844](https://codecov.io/gh/apache/incubator-gobblin/pull/2926?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services