You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Prabhjyot Singh <pr...@gmail.com> on 2017/03/24 18:22:11 UTC

Review Request 57916: configuring Zeppelin's JDBC-phoenix interpreter requires hdfs-site.xml, core-site.xml as well

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57916/
-----------------------------------------------------------

Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.


Bugs: AMBARI-20564
    https://issues.apache.org/jira/browse/AMBARI-20564


Repository: ambari


Description
-------

configuring Zeppelin's JDBC-phoenix interpreter requires hdfs-site.xml, core-site.xml as well


Diffs
-----

  ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py eb6ec01 


Diff: https://reviews.apache.org/r/57916/diff/1/


Testing
-------

Manually on centOS6


Thanks,

Prabhjyot Singh


Re: Review Request 57916: configuring Zeppelin's JDBC-phoenix interpreter requires hdfs-site.xml, core-site.xml as well

Posted by Renjith Kamath <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57916/#review170129
-----------------------------------------------------------


Ship it!




Ship It!

- Renjith Kamath


On March 24, 2017, 6:22 p.m., Prabhjyot Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57916/
> -----------------------------------------------------------
> 
> (Updated March 24, 2017, 6:22 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20564
>     https://issues.apache.org/jira/browse/AMBARI-20564
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> configuring Zeppelin's JDBC-phoenix interpreter requires hdfs-site.xml, core-site.xml as well
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py eb6ec01 
> 
> 
> Diff: https://reviews.apache.org/r/57916/diff/1/
> 
> 
> Testing
> -------
> 
> Manually on centOS6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>


Re: Review Request 57916: configuring Zeppelin's JDBC-phoenix interpreter requires hdfs-site.xml, core-site.xml as well

Posted by Rohit Choudhary <rc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57916/#review170102
-----------------------------------------------------------


Ship it!




Ship It!

- Rohit Choudhary


On March 24, 2017, 6:22 p.m., Prabhjyot Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57916/
> -----------------------------------------------------------
> 
> (Updated March 24, 2017, 6:22 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20564
>     https://issues.apache.org/jira/browse/AMBARI-20564
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> configuring Zeppelin's JDBC-phoenix interpreter requires hdfs-site.xml, core-site.xml as well
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py eb6ec01 
> 
> 
> Diff: https://reviews.apache.org/r/57916/diff/1/
> 
> 
> Testing
> -------
> 
> Manually on centOS6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>


Re: Review Request 57916: configuring Zeppelin's JDBC-phoenix interpreter requires hdfs-site.xml, core-site.xml as well

Posted by Rohit Choudhary <rc...@hortonworks.com>.

> On March 24, 2017, 6:25 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
> > Lines 176 (patched)
> > <https://reviews.apache.org/r/57916/diff/1/?file=1674011#file1674011line176>
> >
> >     Does zeppelin need the full hdfs-site or just a subset?

Conventionally in Zeppelin we've copied the complete config files into the classpath. This specific requirement came from an HA scenario, and I think its okay to copy the file.


- Rohit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57916/#review170042
-----------------------------------------------------------


On March 24, 2017, 6:22 p.m., Prabhjyot Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57916/
> -----------------------------------------------------------
> 
> (Updated March 24, 2017, 6:22 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20564
>     https://issues.apache.org/jira/browse/AMBARI-20564
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> configuring Zeppelin's JDBC-phoenix interpreter requires hdfs-site.xml, core-site.xml as well
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py eb6ec01 
> 
> 
> Diff: https://reviews.apache.org/r/57916/diff/1/
> 
> 
> Testing
> -------
> 
> Manually on centOS6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>


Re: Review Request 57916: configuring Zeppelin's JDBC-phoenix interpreter requires hdfs-site.xml, core-site.xml as well

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57916/#review170042
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
Lines 176 (patched)
<https://reviews.apache.org/r/57916/#comment242800>

    Does zeppelin need the full hdfs-site or just a subset?


- Alejandro Fernandez


On March 24, 2017, 6:22 p.m., Prabhjyot Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57916/
> -----------------------------------------------------------
> 
> (Updated March 24, 2017, 6:22 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20564
>     https://issues.apache.org/jira/browse/AMBARI-20564
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> configuring Zeppelin's JDBC-phoenix interpreter requires hdfs-site.xml, core-site.xml as well
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py eb6ec01 
> 
> 
> Diff: https://reviews.apache.org/r/57916/diff/1/
> 
> 
> Testing
> -------
> 
> Manually on centOS6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>