You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "see-quick (via GitHub)" <gi...@apache.org> on 2026/03/06 12:58:34 UTC
[PR] MINOR: Replace Collections factory methods with Java 11+ equivalents in storage and metadata [kafka]
see-quick opened a new pull request, #21659:
URL: https://github.com/apache/kafka/pull/21659
This PR is another one with changing old JDK 8 API to JDK 11.
Question: I wonder if we should add also parts in test code or simply divide it? I didn't cover tests in my previous PR so maybe to stay consistent just make changes to production code and then we can simply add into tests multiple modules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Replace Collections factory methods with Java 11+ equivalents in storage and metadata [kafka]
Posted by "see-quick (via GitHub)" <gi...@apache.org>.
see-quick commented on PR #21659:
URL: https://github.com/apache/kafka/pull/21659#issuecomment-4015951107
> > Question: I wonder if we should add also parts in test code or simply divide it? I didn't cover tests in my previous PR so maybe to stay consistent just make changes to production code and then we can simply add into tests multiple modules?
>
> If your question is whether you should make similar changes in the test files associated with the files you are changing in this PR or in a separate one, then I will leave the decision up to you 😊
I will keep consistent as part 1 was also only production-only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Replace Collections factory methods with Java 11+ equivalents in storage and metadata [kafka]
Posted by "nileshkumar3 (via GitHub)" <gi...@apache.org>.
nileshkumar3 commented on PR #21659:
URL: https://github.com/apache/kafka/pull/21659#issuecomment-4027451338
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Replace Collections factory methods with Java 11+ equivalents in storage and metadata [kafka]
Posted by "clolov (via GitHub)" <gi...@apache.org>.
clolov commented on PR #21659:
URL: https://github.com/apache/kafka/pull/21659#issuecomment-4011947765
> Question: I wonder if we should add also parts in test code or simply divide it? I didn't cover tests in my previous PR so maybe to stay consistent just make changes to production code and then we can simply add into tests multiple modules?
If your question is whether you should make similar changes in the test files associated with the files you are changing in this PR or in a separate one, then I will leave the decision up to you 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Replace Collections factory methods with Java 11+ equivalents in storage and metadata [kafka]
Posted by "see-quick (via GitHub)" <gi...@apache.org>.
see-quick commented on PR #21659:
URL: https://github.com/apache/kafka/pull/21659#issuecomment-4089815053
Hi @clolov, just checking if there are any additional changes needed to move this PR forward?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Replace Collections factory methods with Java 11+ equivalents in storage and metadata [kafka]
Posted by "clolov (via GitHub)" <gi...@apache.org>.
clolov merged PR #21659:
URL: https://github.com/apache/kafka/pull/21659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org